[MSHARED-1109] Ignore MessageUtilsTest methods on unsupported platforms#106
Merged
asfgit merged 1 commit intoapache:masterfrom Jul 25, 2022
Merged
Conversation
michael-o
requested changes
Jul 25, 2022
src/test/java/org/apache/maven/shared/utils/logging/MessageUtilsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/apache/maven/shared/utils/logging/MessageUtilsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/apache/maven/shared/utils/logging/MessageUtilsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/apache/maven/shared/utils/logging/MessageUtilsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/apache/maven/shared/utils/logging/MessageUtilsTest.java
Outdated
Show resolved
Hide resolved
Member
Author
|
I don't think the test failure is related (https://github.com/apache/maven-shared-utils/runs/7501384171?check_suite_focus=true) |
Member
Correct, since the test expect Jansi to work it does not notice that the OS is not wrapped. |
michael-o
approved these changes
Jul 25, 2022
Member
michael-o
left a comment
michael-o
left a comment
There was a problem hiding this comment.
I can confirm that this fixes the issue on HP-UX for me as well.
michael-o
pushed a commit
to kwin/maven-shared-utils
that referenced
this pull request
Jul 25, 2022
… Apple Silicon or HP-UX/IA64) This closes apache#106
michael-o
force-pushed
the
bugfix/fix-messageutilstest-on-apple-silicon
branch
from
65157b0 to
3f380dd
Compare
kwin
commented
Jul 25, 2022
src/test/java/org/apache/maven/shared/utils/logging/MessageUtilsTest.java
Outdated
Show resolved
Hide resolved
… Apple Silicon or HP-UX/IA64) This closes apache#106
michael-o
force-pushed
the
bugfix/fix-messageutilstest-on-apple-silicon
branch
from
3f380dd to
8822bea
Compare
|
Resolve #310 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.