Skip to content

[MSHARED-1072] fix blocking in StreamFeeder#113

Merged
slawekjaranowski merged 3 commits intomasterfrom
MSHARED-1072
Apr 21, 2023
Merged

[MSHARED-1072] fix blocking in StreamFeeder#113
slawekjaranowski merged 3 commits intomasterfrom
MSHARED-1072

Conversation

@slawekjaranowski
Copy link
Member

@slawekjaranowski slawekjaranowski commented Jul 27, 2022

If input stream has no more available data
StreamFeeder was block forever

@slawekjaranowski
[MSHARED-1072] fix blocking in StreamFeeder
756cd5b 
If input stream has no more available data
StreamFeeder was block forever
michael-o
michael-o requested changes Jul 27, 2022
View reviewed changes
@michael-o michael-o removed their request for review October 23, 2022 09:00
@famod
Copy link

famod commented Mar 17, 2023

Coming from https://issues.apache.org/jira/browse/MRELEASE-1114, what's the status of this? Are there any blockers?

@kwin
Copy link
Member

kwin commented Mar 28, 2023

@slawekjaranowski Given that maven-shared-utils is mostly dead, I am wondering whether you can provide the fix instead for https://github.com/codehaus-plexus/plexus-utils/tree/master/src/main/java/org/codehaus/plexus/util/cli and afterwards we convert maven-gpg-plugin to using plexus-utils again instead of maven-shared-utils.

@michael-o
Copy link
Member

michael-o commented Mar 28, 2023

@slawekjaranowski Given that maven-shared-utils is mostly dead, I am wondering whether you can provide the fix instead for https://github.com/codehaus-plexus/plexus-utils/tree/master/src/main/java/org/codehaus/plexus/util/cli and afterwards we convert maven-gpg-plugin to using plexus-utils again instead of maven-shared-utils.

I think this fix deserves a last patch release and done.

@slawekjaranowski
Copy link
Member Author

slawekjaranowski commented Mar 28, 2023

@slawekjaranowski Given that maven-shared-utils is mostly dead, I am wondering whether you can provide the fix instead for https://github.com/codehaus-plexus/plexus-utils/tree/master/src/main/java/org/codehaus/plexus/util/cli and afterwards we convert maven-gpg-plugin to using plexus-utils again instead of maven-shared-utils.

I think this fix deserves a last patch release and done.

Ok, I will rebase and check again 😄

@slawekjaranowski slawekjaranowski self-assigned this Mar 28, 2023
@michael-o
Copy link
Member

michael-o commented Apr 20, 2023

@slawekjaranowski Do you want to pick this up? I want to relase Maven Release with this fix.

@michael-o michael-o self-requested a review April 20, 2023 19:18
@slawekjaranowski
Merge remote-tracking branch 'origin/master' into MSHARED-1072
587e480 
# Conflicts:
#	src/main/java/org/apache/maven/shared/utils/cli/CommandLineTimeOutException.java
#	src/main/java/org/apache/maven/shared/utils/cli/CommandLineUtils.java
#	src/main/java/org/apache/maven/shared/utils/cli/StreamFeeder.java
@slawekjaranowski
Copy link
Member Author

slawekjaranowski commented Apr 20, 2023

@michael-o refresh with current master, conflict resolved
Tomorrow I would to check again.

@slawekjaranowski
Copy link
Member Author

slawekjaranowski commented Apr 21, 2023

Tested with m-release-p ...

When we want to upgrade version in m-release-p we need #138

@slawekjaranowski slawekjaranowski merged commit b60e8a2 into master Apr 21, 2023
@slawekjaranowski slawekjaranowski deleted the MSHARED-1072 branch April 21, 2023 19:14
@slawekjaranowski slawekjaranowski mentioned this pull request Apr 26, 2023
Merged
@slawekjaranowski slawekjaranowski added the bug Something isn't working label Apr 29, 2023
@jira-importer
Copy link

jira-importer commented Jul 3, 2025

Resolve #313

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michael-o michael-o michael-o approved these changes

Assignees

@slawekjaranowski slawekjaranowski

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@slawekjaranowski @famod @kwin @michael-o @jira-importer