Skip to content

[MSHARED-1196] Bump maven-shared-components from 37 to 39#134

Merged
elharo merged 6 commits intomasterfrom
parent
Mar 12, 2023
Merged

[MSHARED-1196] Bump maven-shared-components from 37 to 39#134
elharo merged 6 commits intomasterfrom
parent

Conversation

@elharo
Copy link
Contributor

@elharo elharo commented Mar 5, 2023

This required a lot of automatic reformatting and a little manual reformatting to make spotless happy

@elharo elharo requested a review from michael-o March 5, 2023 14:31
@elharo elharo changed the title update parent to 39 Bump maven-shared-components from 37 to 39 Mar 5, 2023
michael-o
michael-o requested changes Mar 5, 2023
View reviewed changes
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All license headers in Java files are duplicated.

@elharo elharo changed the title Bump maven-shared-components from 37 to 39 [MSHARED-1196] Bump maven-shared-components from 37 to 39 Mar 5, 2023
@elharo
Copy link
Contributor Author

elharo commented Mar 5, 2023

Ick. I blame spotless, which is not so spotless. Let me see if I can fix that.

@elharo
Copy link
Contributor Author

elharo commented Mar 5, 2023

OK, I think the duplicate licenses are removed. I am very much not a fan of spotless at this point.

elharo
elharo commented Mar 11, 2023
View reviewed changes
Copy link
Contributor Author

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ready for another review. This PR involves a lot more churn than I like, but it appears to be necessary to keep up with the Maven parent POM which is now enforcing a different code style than we used to use.

@elharo
Copy link
Contributor Author

elharo commented Mar 11, 2023

Looks like a few broken Javadoc cross-ref links trip only one of our CIs. Fixing...

                      ^
/home/runner/work/maven-shared-utils/maven-shared-utils/src/main/java/org/apache/maven/shared/utils/logging/package-info.java:26: error: reference not found
 * {@link org.apache.maven.shared.utils.logging.LoggerLevelRenderer LoggerLevelRenderer}.
          ^
/home/runner/work/maven-shared-utils/maven-shared-utils/src/main/java/org/apache/maven/shared/utils/logging/package-info.java:28: error: reference not found
 * {@link org.apache.maven.shared.utils.logging.MessageUtils MessageUtils} gives access to these builders.
          ^
/home/runner/work/maven-shared-utils/maven-shared-utils/src/main/java/org/apache/maven/shared/utils/logging/package-info.java:35: error: reference not found
 * {@link org.apache.maven.shared.utils.logging.LoggerLevelRenderer logger level rendering},</li>
          ^
/home/runner/work/maven-shared-utils/maven-shared-utils/src/main/java/org/apache/maven/shared/utils/logging/package-info.java:37: error: reference not found
 * and <code>project</code> for {@link org.apache.maven.shared.utils.logging.MessageBuilder message content}</li>

@elharo elharo merged commit c75a4ee into master Mar 12, 2023
@elharo elharo deleted the parent branch March 12, 2023 11:40
@slawekjaranowski slawekjaranowski added the dependencies Pull requests that update a dependency file label Apr 29, 2023
@jira-importer
Copy link

jira-importer commented Jul 3, 2025

Resolve #207

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michael-o michael-o michael-o approved these changes

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@elharo @jira-importer @michael-o @slawekjaranowski