[MSHARED-1072] Poll data from input stream#140
Merged
slawekjaranowski merged 1 commit intomasterfrom May 8, 2023
Merged
Conversation
Input stream can be a System.in - all read will be blocked We need read data in no blocking mode
Member
|
Does this always apply? Are there cases were in the stream is not |
Member
Author
It will be safer to use non blocking io in such case. We also can not close provided stream because can be used for multiple executing of invoker. |
michael-o
approved these changes
May 7, 2023
|
Resolve #313 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Input stream can be a System.in - all read will be blocked
We need read data in no blocking mode