Conversation
|
Isn't the test portable already when the proper line separator is used throughout? |
|
It passes on all platforms ATM but it's not testing the same thing on all platforms. E.g. if we had a bug in handling \r\n then the bug wouldn't be seen when running on Linux or the Mac. Or if we had a bug handing \n it wouldn't be found on Windows. |
|
But the purpose of the test is to test the tags and not the line separators? You have removed |
|
The general contract of a unit test is running a function with known, fixed input and comparing it to known fixed output. |
|
Agreed. |
|
Fixing this has revealed some more platform dependent code in our output code which interferes with reproducible builds. |
|
Resolve #273 |
No description provided.