[MNG-6380] Option -Dstyle.color=always doesn't force color output#67
[MNG-6380] Option -Dstyle.color=always doesn't force color output#67elharo merged 1 commit intoapache:masterfrom
Conversation
|
I need to release jansi before merging this PR. |
slachiewicz
left a comment
slachiewicz
left a comment
There was a problem hiding this comment.
I saw that something have changed in relation to unpacking libs. What native lib version will be used if we unpack (for maven core) lib to dedicated directory and set env variables also?
|
I will have a look at this combined with other Maven issues in a few days. |
|
I've pushed commits to leverage today's changes to Jansi. @slachiewicz I'm not sure to understand your question, could you rephrase please ? |
|
Rebased on top of #69 |
gnodet
changed the title
The native libraries location have changed a bit with Jansi 2.x, so we need to properly change the maven distribution, see apache/maven@151e349 |
|
Running through jenkins on branch gnodet |
elharo
left a comment
elharo
left a comment
There was a problem hiding this comment.
JAnsi looks released. Can this be merged?
| <groupId>org.fusesource.jansi</groupId> | ||
| <artifactId>jansi</artifactId> | ||
| <version>2.0.1</version> | ||
| <version>2.2.0</version> |
There was a problem hiding this comment.
We could, but the 2.3.0/2.3.1 only brings two additional native methods specifically for mvnd and no other changes, so there is no real benefit either.
|
@MartinKanters jansi is a dependency both maven-shared and core maven, so it needs to be upgraded in both. In addition, MNG-6380 is resolved with the commits in this PR and not simply the upgrade of jansi. |
…uences are stripped or let through
|
Rebased and squashed. |
|
jenkins passed. |
5 participants
No description provided.