Conversation
|
Maybe |
|
I agree with @slawekjaranowski |
|
Eventually, yes. However it's public API so I don't want to remove it until it's been deprecated for a while longer and ideally we're ready for a major version bump. |
|
I afraid that this never will happened developers don't look for deprecated ... Looking for this class on GitHub I found 4 repositories where it is used, one of them is archived, two don't have any releases so impact will not be huge. |
|
I'm not comfortable removing public API without reasonable notice. Sounds like there are existing uses. |
|
So please deprecate class with reason. Another case is that apache components don't have any release plan / calendar so nobody know when next release will be placed. |
|
@elharo This won't even run in Windows 9x because there isn't Java 7 for. |
|
That still doesn't mean we should break the build of projects that have this in their tree. Deprecate and warn them. We can take it out in a few releases. |
|
|
|
@elharo I guess we can merge this then, right? Nobody had any objections against your code, apart from that we had to deprecate the classes, which @slachiewicz pointed out was done last year. |
@slawekjaranowski