RATIS-2424. Fix javadoc locale configuration for JDK 8 compatibility#1366
Merged
adoroszlai merged 1 commit intoapache:masterfrom Mar 8, 2026
Merged
Conversation
JDK 8's javadoc requires the `-locale` option to be the first argument on the command line. maven-javadoc-plugin cannot guarantee this parameter order. This change uses JVM system properties instead: - `-J-Duser.language=en` - `-J-Duser.country=US` This sets the locale at JVM startup time, before javadoc runs, ensuring compatibility with both JDK 8 and JDK 11+.
OneSizeFitsQuorum
force-pushed
the
RATIS-fix-javadoc-jdk8
branch
from
452606b to
ff7fe06
Compare
adoroszlai
approved these changes
Mar 8, 2026
szetszwo
approved these changes
Mar 8, 2026
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
+1 the change looks good.
Contributor
|
Thanks @OneSizeFitsQuorum for the patch, @szetszwo for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see https://issues.apache.org/jira/browse/RATIS-2424