Fix the heap-use-after-free risk caused by direct deconstruction when it is not used after initialization.#274
Merged
ShannonDing merged 1 commit intoapache:masterfrom Mar 17, 2020
Conversation
… it is not used after initialization.
WoodsCumming
changed the title
Codecov Report
@@ Coverage Diff @@
## master #274 +/- ##
==========================================
+ Coverage 58.28% 58.54% +0.26%
==========================================
Files 182 182
Lines 11805 11810 +5
==========================================
+ Hits 6880 6914 +34
+ Misses 4925 4896 -29
Continue to review full report at Codecov.
|
ShannonDing
approved these changes
Mar 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… it is not used after initialization.
What is the purpose of the change
Fix the heap-use-after-free risk caused by direct deconstruction when it is not used after initialization.
Brief changelog
Fix the heap-use-after-free risk caused by direct deconstruction when it is not used after initialization.
Verifying this change
Want a code review.
The ASAN Report
[==========] Running 2 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 2 tests from MQClientManagerTest
[ RUN ] MQClientManagerTest.getClientFactory
==124436==ERROR: AddressSanitizer: heap-use-after-free on address 0x6110000096f8 at pc
0x7efe51699cba bp 0x7efe4bdfac20 sp 0x7efe4bdfac18
WRITE of size 8 at 0x6110000096f8 thread T4 (RemotingAsioT)
[ OK ] MQClientManagerTest.getClientFactory (14 ms)
[ RUN ] MQClientManagerTest.removeClientFactory
[ OK ] MQClientManagerTest.removeClientFactory (0 ms)
[----------] 2 tests from MQClientManagerTest (14 ms total)
[----------] Global test environment tear-down
[==========] 2 tests from 1 test case ran. (14 ms total)
[ PASSED ] 2 tests.
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.