[SPARK-46919][BUILD][CONNECT] Upgrade grpcio* and grpc-java to 1.62.x#44929
Closed
LuciferYang wants to merge 18 commits intoapache:masterfrom
Closed
[SPARK-46919][BUILD][CONNECT] Upgrade grpcio* and grpc-java to 1.62.x#44929LuciferYang wants to merge 18 commits intoapache:masterfrom
grpcio* and grpc-java to 1.62.x#44929LuciferYang wants to merge 18 commits intoapache:masterfrom
Conversation
LuciferYang
commented
Jan 29, 2024
| <artifactId>grpc-protobuf</artifactId> | ||
| <version>${io.grpc.version}</version> | ||
| </dependency> | ||
| <dependency> |
Contributor
Author
There was a problem hiding this comment.
"io.grpc.protobuf.lite.ProtoLiteUtils has been moved to the grpc-protobuf-lite module, but protobuf-javalite and protobuf-java cannot be used simultaneously because there would be a conflict with com.google.protobuf.Any."
grpcio* 1.60.0grpcio* to 1.60.0 and grpc-java to 1.61.0
srowen
reviewed
Jan 30, 2024
.github/workflows/build_and_test.yml
Outdated
| ipython ipython_genutils sphinx_plotly_directive 'numpy>=1.20.0' pyarrow pandas 'plotly>=4.8' 'docutils<0.18.0' \ | ||
| 'flake8==3.9.0' 'mypy==0.982' 'pytest==7.1.3' 'pytest-mypy-plugins==1.9.3' 'black==23.9.1' \ | ||
| 'pandas-stubs==1.2.0.53' 'grpcio==1.59.3' 'grpc-stubs==1.24.11' 'googleapis-common-protos-stubs==2.2.0' \ | ||
| 'pandas-stubs==1.2.0.53' 'grpcio==1.60.0' 'grpc-stubs==1.24.11' 'googleapis-common-protos-stubs==2.2.0' \ |
Member
There was a problem hiding this comment.
Ah, there is no 1.61.0 on the python side yet?
I think this is OK, but should we stick to 1.61.0 on the JVM side for now then too?
Contributor
Author
There was a problem hiding this comment.
It seems that they are compatible, and grpc-java 1.61.0 brings an additional optimization related to memory use:
so this PR has upgraded grpc-java to version 1.61.0.
Contributor
Author
|
1.61.0 released, mark this one to draft first |
grpcio* to 1.60.0 and grpc-java to 1.61.0grpcio* and grpc-java to 1.62.0
grpcio* and grpc-java to 1.62.0grpcio* and grpc-java to 1.62
grpcio* and grpc-java to 1.62grpcio* and grpc-java to 1.62.x
grpcio* and grpc-java to 1.62.xgrpcio* and grpc-java to 1.62.x
Contributor
Author
|
The version has been unified to the 1.62 series now |
grpcio* and grpc-java to 1.62.xgrpcio* and grpc-java to 1.62.x
dongjoon-hyun
approved these changes
Mar 12, 2024
Member
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @LuciferYang .
Merged to master for Apache Spark 4.0.0.
Contributor
Author
|
Thanks @dongjoon-hyun and @srowen |
dongjoon-hyun
added a commit
that referenced
this pull request
Feb 16, 2025
…sion` to 1.67.0 ### What changes were proposed in this pull request? This PR aims to fix PySpark Connect `_minimum_grpc_version` from 1.59.3 to 1.67.0 correctly. https://github.com/apache/spark/blob/c36916f7a112dc6c6505c12d68c3f63c5aa31db2/python/docs/source/getting_started/install.rst?plain=1#L211 https://github.com/apache/spark/blob/c36916f7a112dc6c6505c12d68c3f63c5aa31db2/dev/spark-test-image/python-minimum/Dockerfile#L76 ### Why are the changes needed? It seems that we missed to this at - #44929 - #48524 ### Does this PR introduce _any_ user-facing change? This will make it sure that PySpark Connect installation meets the minimum requirement correctly. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #49968 from dongjoon-hyun/SPARK-51227. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun
added a commit
that referenced
this pull request
Feb 16, 2025
…sion` to 1.67.0 ### What changes were proposed in this pull request? This PR aims to fix PySpark Connect `_minimum_grpc_version` from 1.59.3 to 1.67.0 correctly. https://github.com/apache/spark/blob/c36916f7a112dc6c6505c12d68c3f63c5aa31db2/python/docs/source/getting_started/install.rst?plain=1#L211 https://github.com/apache/spark/blob/c36916f7a112dc6c6505c12d68c3f63c5aa31db2/dev/spark-test-image/python-minimum/Dockerfile#L76 ### Why are the changes needed? It seems that we missed to this at - #44929 - #48524 ### Does this PR introduce _any_ user-facing change? This will make it sure that PySpark Connect installation meets the minimum requirement correctly. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #49968 from dongjoon-hyun/SPARK-51227. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 3f4ba72) Signed-off-by: Dongjoon Hyun <[email protected]>
zifeif2
pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 14, 2025
…sion` to 1.67.0 ### What changes were proposed in this pull request? This PR aims to fix PySpark Connect `_minimum_grpc_version` from 1.59.3 to 1.67.0 correctly. https://github.com/apache/spark/blob/acc254463533b863b8afe8dccad6565bbff9e35c/python/docs/source/getting_started/install.rst?plain=1#L211 https://github.com/apache/spark/blob/acc254463533b863b8afe8dccad6565bbff9e35c/dev/spark-test-image/python-minimum/Dockerfile#L76 ### Why are the changes needed? It seems that we missed to this at - apache#44929 - apache#48524 ### Does this PR introduce _any_ user-facing change? This will make it sure that PySpark Connect installation meets the minimum requirement correctly. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#49968 from dongjoon-hyun/SPARK-51227. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 52fc668) Signed-off-by: Dongjoon Hyun <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to upgrade
grpcio*from 1.59.3 to 1.62.0andgrpc-javafrom 1.59.0 to 1.62.2 for Apache Spark 4.0.0.Why are the changes needed?
grpc 1.60.0 start to support dualstack IPv4 and IPv6 backend support:
Note that in
grpc-java1.61.0, since the dependency scope ofgrpc-protobufongrpc-protobuf-litehas been changed fromcompiletoruntime, we need to manually configure the dependency of theconnectmodule ongrpc-protobuf-liteand explicitly exclude the dependency onprotobuf-javalitebecauseSparkConnectServiceusesio.grpc.protobuf.lite.ProtoLiteUtilsThe relevant release notes are as follows:
Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass GitHub Actions
Was this patch authored or co-authored using generative AI tooling?
No