[SPARK-53138][CORE][BUILD] Split common-utils Java code into a new module by pan3793 · Pull Request #51868 · apache/spark

pan3793 · 2025-08-06T06:49:48Z

What changes were proposed in this pull request?

This PR splits the Java code of common/utils into a new module common/utils-java, except for:

common/utils/src/main/java/org/apache/spark/storage/StorageLevelMapper.java
common/utils/src/main/java/org/apache/spark/SparkThrowable.java

A few utility methods are rewritten in Java to avoid depending on scala-library.

Why are the changes needed?

To make YARN ESS (common/network-yarn) scala-free again.

Read the discussion of SPARK-52942 (#51650) for more details and the following PR.

[SPARK-53064][CORE] Rewrite MDC LogKey in Java #51775

Does this PR introduce any user-facing change?

No.

How was this patch tested?

$ build/mvn -pl common/network-yarn -am clean package -DskipTests -Pyarn
...
[INFO] Including org.apache.spark:spark-network-shuffle_2.13:jar:4.1.0-SNAPSHOT in the shaded jar.
[INFO] Including org.apache.spark:spark-network-common_2.13:jar:4.1.0-SNAPSHOT in the shaded jar.
[INFO] Including io.netty:netty-all:jar:4.1.123.Final in the shaded jar.
[INFO] Including io.netty:netty-buffer:jar:4.1.123.Final in the shaded jar.
[INFO] Including io.netty:netty-codec:jar:4.1.123.Final in the shaded jar.
[INFO] Including io.netty:netty-codec-dns:jar:4.1.123.Final in the shaded jar.
[INFO] Including io.netty:netty-codec-http:jar:4.1.123.Final in the shaded jar.
[INFO] Including io.netty:netty-codec-http2:jar:4.1.123.Final in the shaded jar.
[INFO] Including io.netty:netty-codec-socks:jar:4.1.123.Final in the shaded jar.
[INFO] Including io.netty:netty-common:jar:4.1.123.Final in the shaded jar.
[INFO] Including io.netty:netty-handler:jar:4.1.123.Final in the shaded jar.
[INFO] Including io.netty:netty-transport-native-unix-common:jar:4.1.123.Final in the shaded jar.
[INFO] Including io.netty:netty-handler-proxy:jar:4.1.123.Final in the shaded jar.
[INFO] Including io.netty:netty-resolver:jar:4.1.123.Final in the shaded jar.
[INFO] Including io.netty:netty-resolver-dns:jar:4.1.123.Final in the shaded jar.
[INFO] Including io.netty:netty-transport:jar:4.1.123.Final in the shaded jar.
[INFO] Including io.netty:netty-transport-classes-epoll:jar:4.1.123.Final in the shaded jar.
[INFO] Including io.netty:netty-transport-classes-kqueue:jar:4.1.123.Final in the shaded jar.
[INFO] Including io.netty:netty-transport-native-epoll:jar:linux-riscv64:4.1.123.Final in the shaded jar.
[INFO] Including io.netty:netty-transport-native-epoll:jar:linux-x86_64:4.1.123.Final in the shaded jar.
[INFO] Including io.netty:netty-transport-native-epoll:jar:linux-aarch_64:4.1.123.Final in the shaded jar.
[INFO] Including io.netty:netty-transport-native-kqueue:jar:osx-aarch_64:4.1.123.Final in the shaded jar.
[INFO] Including io.netty:netty-transport-native-kqueue:jar:osx-x86_64:4.1.123.Final in the shaded jar.
[INFO] Including io.netty:netty-tcnative-boringssl-static:jar:linux-x86_64:2.0.72.Final in the shaded jar.
[INFO] Including io.netty:netty-tcnative-classes:jar:2.0.72.Final in the shaded jar.
[INFO] Including io.netty:netty-tcnative-boringssl-static:jar:windows-x86_64:2.0.72.Final in the shaded jar.
[INFO] Including io.netty:netty-tcnative-boringssl-static:jar:linux-aarch_64:2.0.72.Final in the shaded jar.
[INFO] Including io.netty:netty-tcnative-boringssl-static:jar:osx-aarch_64:2.0.72.Final in the shaded jar.
[INFO] Including io.netty:netty-tcnative-boringssl-static:jar:osx-x86_64:2.0.72.Final in the shaded jar.
[INFO] Including org.fusesource.leveldbjni:leveldbjni-all:jar:1.8 in the shaded jar.
[INFO] Including org.rocksdb:rocksdbjni:jar:9.8.4 in the shaded jar.
[INFO] Including com.fasterxml.jackson.core:jackson-databind:jar:2.19.2 in the shaded jar.
[INFO] Including com.fasterxml.jackson.core:jackson-core:jar:2.19.2 in the shaded jar.
[INFO] Including com.fasterxml.jackson.core:jackson-annotations:jar:2.19.2 in the shaded jar.
[INFO] Including org.apache.commons:commons-crypto:jar:1.1.0 in the shaded jar.
[INFO] Including com.google.crypto.tink:tink:jar:1.16.0 in the shaded jar.
[INFO] Including com.google.code.gson:gson:jar:2.11.0 in the shaded jar.
[INFO] Including org.apache.spark:spark-common-utils-java_2.13:jar:4.1.0-SNAPSHOT in the shaded jar.
[INFO] Including org.slf4j:jul-to-slf4j:jar:2.0.17 in the shaded jar.
[INFO] Including org.slf4j:jcl-over-slf4j:jar:2.0.17 in the shaded jar.
[INFO] Including org.apache.logging.log4j:log4j-slf4j2-impl:jar:2.24.3 in the shaded jar.
[INFO] Including org.apache.logging.log4j:log4j-api:jar:2.24.3 in the shaded jar.
[INFO] Including org.apache.logging.log4j:log4j-core:jar:2.24.3 in the shaded jar.
[INFO] Including org.apache.logging.log4j:log4j-1.2-api:jar:2.24.3 in the shaded jar.
[INFO] Including org.apache.logging.log4j:log4j-layout-template-json:jar:2.24.3 in the shaded jar.
[INFO] Including org.apache.commons:commons-lang3:jar:3.18.0 in the shaded jar.
[INFO] Including io.dropwizard.metrics:metrics-core:jar:4.2.32 in the shaded jar.
[INFO] Including org.roaringbitmap:RoaringBitmap:jar:1.3.0 in the shaded jar.
[INFO] Including com.google.code.findbugs:jsr305:jar:3.0.0 in the shaded jar.
[INFO] Including org.spark-project.spark:unused:jar:1.0.0 in the shaded jar.
...

Now, YARN ESS jar is scala-free, rocksdbjni and netty contribute the major size.

$ ll common/network-yarn/target/scala-2.13/spark-4.1.0-SNAPSHOT-yarn-shuffle.jar                 
-rw-r--r--@ 1 chengpan  staff    92M Aug  6 16:54 common/network-yarn/target/scala-2.13/spark-4.1.0-SNAPSHOT-yarn-shuffle.jar
$ jar tf common/network-yarn/target/scala-2.13/spark-4.1.0-SNAPSHOT-yarn-shuffle.jar | grep scala
<no-output>
$ ll ~/.m2/repository/org/rocksdb/rocksdbjni/9.8.4/rocksdbjni-9.8.4.jar         
-rw-r--r--@ 1 chengpan  staff    68M Jan 12  2025 /Users/chengpan/.m2/repository/org/rocksdb/rocksdbjni/9.8.4/rocksdbjni-9.8.4.jar

Was this patch authored or co-authored using generative AI tooling?

No.

pan3793 · 2025-08-06T06:50:41Z

common/utils-java/src/main/java/org/apache/spark/network/util/JavaUtils.java

not sure if the style is right here

pan3793 · 2025-08-06T06:52:16Z

common/variant/src/main/java/org/apache/spark/types/variant/VariantUtil.java

common/variant still depends on common/utils(Scala) because this is a Scala class

pan3793 · 2025-08-06T08:22:43Z

common/network-yarn/pom.xml

this does not change the output of artifacts, but is required to fix the scaladocs packaging

[INFO] --- scala:4.9.5:doc-jar (attach-scaladocs) @ spark-network-yarn_2.13 --- scaladoc error: fatal error: object scala in compiler mirror not found.

pan3793 · 2025-08-06T10:29:39Z

this is ready for review, cc @LuciferYang @mridulm @dongjoon-hyun

dongjoon-hyun

Thank you for this approach, @pan3793 .

LuciferYang · 2025-08-07T11:22:42Z

.github/workflows/build_and_test.yml

Similar changes should be incorporated into the maven_test.yml file. Meanwhile, both of these files should be utilized for the daily tests of branch-4.0/3.5. It is necessary to consider compatibility issues arising from the absence of certain modules in the relevant branches.

Seems branch-3.5 does not have the Maven daily test, I changed maven_test.yml in 21c892f99bcac44b28038ab1a0fd1034d09d3bc4, please help check.

LuciferYang

The cost of rewriting the Scala code in common-utils into Java would be significant. If we want to address this issue but have no better alternative, then I accept this solution.

But let's wait for others' opinions.

pan3793 · 2025-08-08T08:24:05Z

Rebased to resolve conflicts

pan3793 · 2025-08-11T02:35:04Z

Rebased to resolve conflicts

LuciferYang · 2025-08-11T02:45:26Z

If there are no objections within 24 hours, I will merge this one

LuciferYang · 2025-08-12T05:50:16Z

Merged into master for Apache Spark 4.1.0. Thanks @pan3793 and @dongjoon-hyun

github-actions bot added SQL BUILD CORE labels Aug 6, 2025

pan3793 commented Aug 6, 2025

View reviewed changes

common/utils-java/src/main/java/org/apache/spark/network/util/JavaUtils.java Outdated

Copy link

Member Author

pan3793 Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if the style is right here

pan3793 commented Aug 6, 2025

View reviewed changes

pan3793 changed the title ~~[SPARK-53138] Split common-utils Java code into a new module~~ [SPARK-53138][CORE][BUILD] Split common-utils Java code into a new module Aug 6, 2025

pan3793 force-pushed the SPARK-53138 branch from fab0894 to e9b2ac1 Compare August 6, 2025 07:50

pan3793 commented Aug 6, 2025

View reviewed changes

github-actions bot added the INFRA label Aug 6, 2025

dongjoon-hyun reviewed Aug 6, 2025

View reviewed changes

LuciferYang reviewed Aug 7, 2025

View reviewed changes

pan3793 force-pushed the SPARK-53138 branch from 424a551 to 21c892f Compare August 7, 2025 11:39

LuciferYang reviewed Aug 7, 2025

View reviewed changes

pan3793 force-pushed the SPARK-53138 branch from 21c892f to 78256cb Compare August 8, 2025 08:23

pan3793 force-pushed the SPARK-53138 branch from 78256cb to 514b7aa Compare August 11, 2025 02:28

pan3793 added 11 commits August 12, 2025 10:46

wip

d2cc2a1

mv StorageLevelMapper back to common/utils

944ff9a

mv SparkThrowable back to common/utils

0329f9e

complete

14fac4a

fix

0eae920

fix

83a27c3

fix mima

f1e7077

dix docs

f29780d

gha

c228fb7

strip deps

865dec2

fix test

3d28202

pan3793 added 2 commits August 12, 2025 11:06

maven workflow

53e12eb

Resolve conflicts

f7a9867

pan3793 force-pushed the SPARK-53138 branch from 514b7aa to f7a9867 Compare August 12, 2025 03:09

LuciferYang closed this in 6537153 Aug 12, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SPARK-53138][CORE][BUILD] Split common-utils Java code into a new module#51868

[SPARK-53138][CORE][BUILD] Split common-utils Java code into a new module#51868
pan3793 wants to merge 13 commits intoapache:masterfrom
pan3793:SPARK-53138

pan3793 commented Aug 6, 2025 •

edited by dongjoon-hyun

Loading

Uh oh!

pan3793 Aug 6, 2025

Uh oh!

pan3793 Aug 6, 2025

Uh oh!

pan3793 Aug 6, 2025

Uh oh!

pan3793 commented Aug 6, 2025

Uh oh!

dongjoon-hyun left a comment •

edited

Loading

Uh oh!

LuciferYang Aug 7, 2025

Uh oh!

pan3793 Aug 7, 2025

Uh oh!

LuciferYang left a comment •

edited

Loading

Uh oh!

pan3793 commented Aug 8, 2025

Uh oh!

pan3793 commented Aug 11, 2025

Uh oh!

LuciferYang commented Aug 11, 2025

Uh oh!

LuciferYang commented Aug 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

pan3793 commented Aug 6, 2025 • edited by dongjoon-hyun Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

Was this patch authored or co-authored using generative AI tooling?

Uh oh!

pan3793 Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

pan3793 Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

pan3793 Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

pan3793 commented Aug 6, 2025

Uh oh!

dongjoon-hyun left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LuciferYang Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

pan3793 Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

LuciferYang left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pan3793 commented Aug 8, 2025

Uh oh!

pan3793 commented Aug 11, 2025

Uh oh!

LuciferYang commented Aug 11, 2025

Uh oh!

LuciferYang commented Aug 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pan3793 commented Aug 6, 2025 •

edited by dongjoon-hyun

Loading

dongjoon-hyun left a comment •

edited

Loading

LuciferYang left a comment •

edited

Loading