This repository was archived by the owner on Nov 20, 2018. It is now read-only.
Faster StartsWithSegments Ordinal check#521
Closed
benaadams wants to merge 1 commit intoaspnet:devfrom
Closed
Conversation
Contributor
Author
|
As an aside; the sets and whatnot have high costs as they are also doing dictionary lookups; typecasts and initalizing the feature cache |
Member
|
Do you have any thoughts @Tratcher? |
Member
|
Not a fan of this. Looks pretty unmaintainable. Is it really worth it? Can we make a change like this in corefx instead? |
Contributor
Author
|
Would be change to coreclr https://github.com/dotnet/coreclr/blob/master/src/mscorlib/src/System/String.cs#L2562 Will propose. |
Member
|
@davidfowl No less maintainable than I see your point though. This is something probably done once per request at most, and I doubt most apps are even going to specify |
Contributor
Author
|
@halter73 The crazy is currently localized to one project :) |
Contributor
Author
|
Raised PR in coreclr dotnet/coreclr#2667 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Framework's call to native comes with a cost
Before
After
