Conversation
|
@JunTaoLuo told me it only made about a 1% improvement in /plaintext benchmark. He's testing again with more headers. If it doesn't make that much of a difference, I think we just close this to keep things simpler. |
|
Here are the results I'm getting from benchmarks: I tried the plaintext benchmarks with the headers I get from going to github.com: Using pre-encoded headers after about 10 runs: Median-ish (just eyeballing): Worst: Best: Not pre-encoding after about 10 runs: Median-ish (just eyeballing): Worst: Best: This yields about 4-7% improvement when using pre-encoded headers. |
|
After speaking with @halter73 we decided that the minor improvement here isn't valuable ~1% improvement for the plaintext benchmark and ~4-7% when there are many headers. |
Continuing from #491