Skip to content

Display output severity in preview#23845

Merged
dylwil3 merged 12 commits intomainfrom
dylan/output-severity
Mar 13, 2026
Merged

Display output severity in preview#23845
dylwil3 merged 12 commits intomainfrom
dylan/output-severity

Conversation

@dylwil3
Copy link
Collaborator

@dylwil3 dylwil3 commented Mar 9, 2026

This is just the "aesthetic" part of implementing warning severities. Configuration changes are in #23846

It's expected that the preview ecosystem check times out here.

@dylwil3 dylwil3 added preview Related to preview mode features diagnostics Related to reporting of diagnostics. labels Mar 9, 2026
@dylwil3 dylwil3 force-pushed the dylan/output-severity branch from a6581ba to 50a35d7 Compare March 9, 2026 20:22
@dylwil3 dylwil3 changed the title [WIP] Display output severity in preview Display output severity in preview Mar 10, 2026
@dylwil3 dylwil3 marked this pull request as ready for review March 10, 2026 13:58
@dylwil3 dylwil3 requested review from amyreese and ntBre and removed request for carljm, dcreager and sharkdp March 10, 2026 13:58
@ntBre ntBre assigned ntBre and unassigned carljm Mar 10, 2026
Copy link
Contributor

@ntBre ntBre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this looks good to me!

We did some light bikeshedding on the colon after the severity brackets in #19644, but I think what you have looks nice.

@dylwil3 dylwil3 force-pushed the dylan/output-severity branch from 33fdbb8 to cb221a4 Compare March 13, 2026 14:18
@dylwil3 dylwil3 force-pushed the dylan/output-severity branch from cb221a4 to e11289c Compare March 13, 2026 14:43
@dylwil3 dylwil3 merged commit 5f1a12e into main Mar 13, 2026
45 of 46 checks passed
@dylwil3 dylwil3 deleted the dylan/output-severity branch March 13, 2026 14:56
dylwil3 added a commit that referenced this pull request Mar 13, 2026
…nstead of checking preview disabled directly (#23950)

Minor followup to #23845 - I forgot one spot where we should use the
`preview.rs` function instead of `preview.is_disabled()`.
carljm added a commit that referenced this pull request Mar 16, 2026
* main: (131 commits)
  [ty] Fixup examples in `invalid-key` docs (#23968)
  [ty] Fix compiler warning about unused variable (#23967)
  [ty] Sync vendored typeshed stubs (#23963)
  Add a `.git-blame-ignore-revs` file (#23959)
  Revert "[ty] Completely remove the `NoReturn` shortcut optimization" (#23955)
  [ty] Completely remove the `NoReturn` shortcut optimization (#23378)
  [ty] Introduce fast path for protocol non-assignability (#23952)
  Bump typing conformance suite SHA (#23951)
  Minor followup to severity display - use preview function in server instead of checking preview disabled directly (#23950)
  Document editor features for markdown code formatting (#23924)
  [ty] Add `with_recursion_guard()` helpers to `relation.rs` (#23945)
  [ty] Remove `check_optional_method_pair` methods (#23947)
  [ty] Remove unused `CycleDetector::try_visit` method (#23944)
  [ty] Ensure TypedDict subscripts for unknown keys return Unknown (#23926)
  [ty] Fix variance of frozen dataclass-transform models (#23931)
  Display output severity in preview (#23845)
  Revert "[`ruff`] use `bitcode` instead of `bincode`" (#23935)
  Fix shell injection via `shell=True` in subprocess calls (#23894)
  [ty] Refactor `relation.rs` to store state on a struct rather than passing around 7 arguments every time we recurse (#23837)
  Don't return code actions for non-Python documents (#23905)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

diagnostics Related to reporting of diagnostics. preview Related to preview mode features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants