Skip to content

Revert "[ruff] use bitcode instead of bincode"#23935

Merged
MichaReiser merged 1 commit intomainfrom
revert-23544-bitcode
Mar 13, 2026
Merged

Revert "[ruff] use bitcode instead of bincode"#23935
MichaReiser merged 1 commit intomainfrom
revert-23544-bitcode

Conversation

@MichaReiser
Copy link
Member

Reverts #23544

bitcode depends on unsound code.

@MichaReiser MichaReiser added the internal An internal refactor or improvement label Mar 13, 2026
@astral-sh-bot astral-sh-bot bot requested a review from ntBre March 13, 2026 14:23
@astral-sh-bot
Copy link

astral-sh-bot bot commented Mar 13, 2026

Typing conformance results

No changes detected ✅

Current numbers
The percentage of diagnostics emitted that were expected errors held steady at 85.29%. The percentage of expected errors that received a diagnostic held steady at 78.13%. The number of fully passing files held steady at 64/132.

@astral-sh-bot
Copy link

astral-sh-bot bot commented Mar 13, 2026

Memory usage report

Memory usage unchanged ✅

@astral-sh-bot
Copy link

astral-sh-bot bot commented Mar 13, 2026

mypy_primer results

No ecosystem changes detected ✅

@astral-sh-bot
Copy link

astral-sh-bot bot commented Mar 13, 2026

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

ℹ️ ecosystem check encountered format errors. (no format changes; 1 project error)

langchain-ai/langchain (error)

ruff format --preview

warning: Detected debug build without --no-cache.
warning: Failed parse cache file `/home/runner/work/ruff/ruff/checkouts/langchain-ai:langchain/libs/langchain/.ruff_cache/0.15.6/17298799970501529372`: InvalidIntegerType { expected: U32, found: Reserved }
warning: Failed parse cache file `/home/runner/work/ruff/ruff/.ruff_cache/0.15.6/17394387964977417435`: InvalidBooleanValue(137)
warning: Failed parse cache file `/home/runner/work/ruff/ruff/checkouts/langchain-ai:langchain/libs/partners/huggingface/.ruff_cache/0.15.6/1145356442822826108`: InvalidBooleanValue(27)
warning: Failed parse cache file `/home/runner/work/ruff/ruff/checkouts/langchain-ai:langchain/libs/partners/openai/.ruff_cache/0.15.6/2816801090053657342`: InvalidBooleanValue(29)

error: Ruff crashed. If you could open an issue at:

    https://github.com/astral-sh/ruff/issues/new?title=%5BPanic%5D

...quoting the executed command, along with the relevant file contents and `pyproject.toml` settings, we'd be very appreciative!


thread '<unnamed>' (19717) panicked at /rust/deps/hashbrown-0.16.1/src/raw/mod.rs:37:40:
Hash table capacity overflow
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

@MichaReiser MichaReiser merged commit 04d8a66 into main Mar 13, 2026
51 of 52 checks passed
@MichaReiser MichaReiser deleted the revert-23544-bitcode branch March 13, 2026 14:40
carljm added a commit that referenced this pull request Mar 16, 2026
* main: (131 commits)
  [ty] Fixup examples in `invalid-key` docs (#23968)
  [ty] Fix compiler warning about unused variable (#23967)
  [ty] Sync vendored typeshed stubs (#23963)
  Add a `.git-blame-ignore-revs` file (#23959)
  Revert "[ty] Completely remove the `NoReturn` shortcut optimization" (#23955)
  [ty] Completely remove the `NoReturn` shortcut optimization (#23378)
  [ty] Introduce fast path for protocol non-assignability (#23952)
  Bump typing conformance suite SHA (#23951)
  Minor followup to severity display - use preview function in server instead of checking preview disabled directly (#23950)
  Document editor features for markdown code formatting (#23924)
  [ty] Add `with_recursion_guard()` helpers to `relation.rs` (#23945)
  [ty] Remove `check_optional_method_pair` methods (#23947)
  [ty] Remove unused `CycleDetector::try_visit` method (#23944)
  [ty] Ensure TypedDict subscripts for unknown keys return Unknown (#23926)
  [ty] Fix variance of frozen dataclass-transform models (#23931)
  Display output severity in preview (#23845)
  Revert "[`ruff`] use `bitcode` instead of `bincode`" (#23935)
  Fix shell injection via `shell=True` in subprocess calls (#23894)
  [ty] Refactor `relation.rs` to store state on a struct rather than passing around 7 arguments every time we recurse (#23837)
  Don't return code actions for non-Python documents (#23905)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal An internal refactor or improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants