Don't show noqa hover for non-Python documents#24040
Merged
MichaReiser merged 1 commit intoastral-sh:mainfrom Mar 19, 2026
Merged
Don't show noqa hover for non-Python documents#24040MichaReiser merged 1 commit intoastral-sh:mainfrom
MichaReiser merged 1 commit intoastral-sh:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #23860
After PR #23905 fixed code actions appearing in non-Python documents, the noqa hover tooltip still appeared in markdown files. For example, hovering over
# noqa: RUF100in a markdown file would show a tooltip explaining the RUF100 rule, even though#is a heading marker in markdown, not a Python comment.Added a
SourceType::Pythonguard at the top of thehover()function, following the same pattern used incode_action.rs.Test Plan
Added two unit tests in
hover.rs:no_hover_for_markdown: opens a.mdfile containing# noqa: RUF100and verifies hover returnsNonehover_for_python_noqa: opens a.pyfile containing# noqa: RUF100and verifies hover returns a tooltipTo run the tests:
Expected output: