Merged
Conversation
Deploying darkwrite with
|
| Latest commit: |
8123179
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2077ded5.darkwrite.pages.dev |
| Branch Preview URL: | https://pnpm-monorepo.darkwrite.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the way
electron-builderworks and our project is set up, approximately ~80-100MiB of frontend dependencies leak into the final ASAR archive. None of these dependencies need to exist during runtime, as Vite already bundles them into at most a few .js files.This will be resolved by switching to a monorepo structure with (at least) the following packages:
Sources have been moved with
git mvto retain file history.Merging this will remove cut ~80-100MB of unused frontend dependencies by detaching the frontend from Electron related sources altogether.