Skip to content

Config v3#337

Merged
Blacksmoke16 merged 66 commits intomasterfrom
config-v3
Feb 4, 2024
Merged

Config v3#337
Blacksmoke16 merged 66 commits intomasterfrom
config-v3

Conversation

@Blacksmoke16
Copy link
Member

@Blacksmoke16 Blacksmoke16 commented Dec 19, 2023 •
edited
Loading

Initial implementation of the next-gen way to configure/extend Athena:

  • Removes ACF::Base, ACF::Parameters, Resolvable annotation, and the load_* class methods
    • These features are being merged into the DI component
  • Revamps the DI component to leverage a more powerful implementation
    • Removes dep on the config component
    • Extract the various modules into more isolated files/modules into new "compiler pass" concept
    • More robust way to adding/customizing order of said compiler passes
    • Parameters are more statically defined and known at compile time, with placeholders being able to recursively resolve them

TODO:

  • - Integrate new concept into rest of framework Config v3 framework integration #383
  • - (follow up) Better way to handle ENV vars
    • Including processors for common ENV operations
  • - (follow up) Look into deprecating some features/replacing some with new annotations
  • - (follow up) Service call & setter DI Support service calls #384

Resolves #332

@Blacksmoke16
Start prototyping explicit configuration
cf72ef5 
Support resolving parameter placeholder values
@Blacksmoke16
Support resolving parameters in array values
48e5d4a
@Blacksmoke16
Document what is going on so I remember in the future
95b16a4
@Blacksmoke16
Merge param resolution loops into one
800bd11 
Add invalid parameter error handling
@Blacksmoke16
Start to revamp how dependencies are resolved
e985aa2
@Blacksmoke16
Break up value collection logic into multiple modules
159bfd4
@Blacksmoke16
Better support bindings
c41537e 
Start on autoconfiguration
Define getters
First pass on aliases
@Blacksmoke16
Specs for parameter resolution
c3dc5b8
@Blacksmoke16
Start on test coverage
9830c92 
Support generic services
Fix factories
@Blacksmoke16
Remove param/config functionality from config component
d26f05a 
First pass on tag support
@Blacksmoke16
Break out compilation stages into their own files
9d906ce 
Support injecting tagged services
@Blacksmoke16
Actually push the new stage files
0fe5744
@Blacksmoke16
First pass at extension support
6624fd2
@Blacksmoke16
Handle constant values
ca5a6d9
@Blacksmoke16
Checkpoint on recursive type checking
407f9ae
@Blacksmoke16
Handle non-nilable named tuple values
dc1c5d8
@Blacksmoke16
Handle unexpected top-level keys
41291bc 
Add test coverage for error states
Remove debugging code
@Blacksmoke16
Actually push new test file
29d24d1
@Blacksmoke16
WIP handling root level values
3aedcbe
@Blacksmoke16
Work on root level error handling
1114634
@Blacksmoke16
Merge master & resolve conflicts
afe7daa
@Blacksmoke16
Initial prototype of type based extensions
5dda017
@Blacksmoke16
Get extra keys somewhat working
2bd2d38
@Blacksmoke16
Handle un-registered extensions
51aee3a 
Handle unexpected keys in extension child namespaces with no options
@Blacksmoke16
I think its working?
1eb3df2
@Blacksmoke16
Handle validating parameters used in configuration after they are res…
1018a4d 
…olved
@Blacksmoke16
Allow root extension to be a module
35e90b1 
Get specs running
@Blacksmoke16
Start of updating register extensions stage specs
d54fd1b
@Blacksmoke16
Get first batch of specs working
33ef262
@Blacksmoke16
Add nested level specs
2d8e5d6
@Blacksmoke16
Copy link
Member Author

Blacksmoke16 commented Dec 31, 2023

This still needs a pass on docs, but going to merge as is given CI is happy and it's already a big boi PR.

@Blacksmoke16
Copy link
Member Author

Blacksmoke16 commented Feb 3, 2024

So getting back to this and working on remembering where I left off. It seems I'd like to merge this to make future changes more focused. Also seems this is in a working spot, but some things still need wired up. E.g. enabling cors/format handler stuff if configured to do so.

Probably fine merging as is, then following up with a PR to get that stuff working.

Blacksmoke16
Blacksmoke16 commented Feb 4, 2024
View reviewed changes
src/components/framework/src/bundle.cr
end
end

module Extension
Copy link
Member Author

@Blacksmoke16 Blacksmoke16 Feb 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO for a follow up PR: Register/configure CORS and format listeners based on configuration.

@Blacksmoke16 Blacksmoke16 marked this pull request as ready for review February 4, 2024 17:15
@Blacksmoke16 Blacksmoke16 merged commit b9a9659 into master Feb 4, 2024
@Blacksmoke16 Blacksmoke16 deleted the config-v3 branch February 4, 2024 18:10
@Blacksmoke16 Blacksmoke16 mentioned this pull request Feb 23, 2024
Closed
@Blacksmoke16 Blacksmoke16 mentioned this pull request Mar 19, 2024
Closed
This was referenced Mar 29, 2024
Closed
Merged
Merged
Closed
@Blacksmoke16 Blacksmoke16 mentioned this pull request Dec 11, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

breaking component:config component:dependency-injection component:framework

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Configuring Athena Framework

1 participant

@Blacksmoke16