This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Capture regexp begin/end as punctuation in Clojure syntax#66
Merged
winstliu merged 2 commits intoatom:masterfrom Apr 28, 2017
tonsky:patch-2
Merged
Capture regexp begin/end as punctuation in Clojure syntax#66winstliu merged 2 commits intoatom:masterfrom tonsky:patch-2
winstliu merged 2 commits intoatom:masterfrom
tonsky:patch-2
Conversation
winstliu
reviewed
Apr 28, 2017
grammars/clojure.cson
Outdated
| @@ -232,7 +232,13 @@ | |||
| ] | |||
| 'regexp': | |||
| 'begin': '#\\"' | |||
Contributor
There was a problem hiding this comment.
🎨 Quotes don't need to be escaped.
Contributor
|
Looks like specs need to be updated. |
Contributor
Author
|
I’ve updated specs |
Contributor
Author
|
Can you cut a release please? |
Contributor
|
Is there a specific reason you'd like a new release? I'm only planning to publish a new release after Atom 1.17.0 is released since this is a bundled package. |
Contributor
Author
|
The only reason is I want to use the stuff :) But it’s not showstopper, so please follow whatever release process you’re comfortable with. When is Atom 1.17.0 due? |
Contributor
|
I can't give an exact date, but probably sometime this month. If you really want to use it right now, you can install the package as a git package (pasting |
Contributor
Author
|
Thanks!
…On Wed, May 3, 2017 at 12:21 AM Wliu ***@***.***> wrote:
I can't give an exact date, but *probably* sometime this month. If you
really want to use it right now, you can install the package as a git
package (pasting https://github.com/atom/language-clojure into the
Install dialog in Settings View should work).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#66 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AARabEOdXGTvyb-2R5HAEKOgwNV0dnAAks5r155LgaJpZM4NLNPr>
.
|
Slowki
pushed a commit
to Slowki/hy.tmLanguage
that referenced
this pull request
Sep 14, 2018
Capture regexp begin/end as punctuation in Clojure syntax
Slowki
pushed a commit
to Slowki/hy.tmLanguage
that referenced
this pull request
Sep 14, 2018
Capture regexp begin/end as punctuation in Clojure syntax
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
When highlighting regexp, starting
#"and ending"should be of classpunctuation. That is done e.g. for strings but was forgotten for regexpesAlternate Designs
This is a very simple change. I believe there’s only one way to do it.
Benefits
Regexpes are highlighted the same way everything else is (e.g. strings, vectors, maps).
Possible Drawbacks
None
Applicable Issues
None