Added support to allow pasting as Markdown table#36
Added support to allow pasting as Markdown table#36atsyplenkov merged 5 commits intoatsyplenkov:masterfrom
Conversation
|
Thanks for your PR, markdown tables were in a roadmap for very long time. I will review your submission next week |
|
@cursor review |
![cursor[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
atsyplenkov
left a comment
atsyplenkov
left a comment
There was a problem hiding this comment.
Thanks for the PR, it's looking pretty good. I've noticed that you used some custom emoji, can you please replace them with Unicode Standardized ones? Currently they are not properly rendering in the web and across platforms.
Additionally Cursor found a bug, please, fix it
package.json
Outdated
| "pastum.defaultAligmentMarkdown": { | ||
| "type": "string", | ||
| "enum": [ | ||
| "columnar ▥", |
There was a problem hiding this comment.
emoji characters unfortunately don’t render consistently across browsers and platforms. Can you please replace them with ones from Unicode List? https://www.unicode.org/emoji/charts/full-emoji-list.html
There was a problem hiding this comment.
Fixed in 1a25729.
Please let me know if you find any icon that better represents the format differences.
src/paste-markdown.js
Outdated
| // 3: Ask the user which aligment they want to use | ||
| if (aligment === null) { | ||
| aligment = await vscode.window.showQuickPick( | ||
| ["columnar ▥", "compact 🗉"], |
There was a problem hiding this comment.
Same comment here regarding the emoji
|
@cursor review |
src/paste-markdown.js
Outdated
| * Generates a markdown table. | ||
| * Supports columnar and compact aligments. | ||
| */ | ||
| function createMarkdown(tableData, aligment) { |
There was a problem hiding this comment.
Bug: Inconsistent Emoji Usage and Typo Error
The quickpick options for table alignment use inconsistent emojis (e.g., 'columnar ↩️') compared to the package.json configuration enum ('columnar
There was a problem hiding this comment.
Good catch, Cursor! 🥇
atsyplenkov
left a comment
atsyplenkov
left a comment
There was a problem hiding this comment.
Thanks, I've just tested and everything is cool. Will merge in main
2 participants
No description provided.