Parse tables from CSV, TSV, and fixed space delimted formats#38
Parse tables from CSV, TSV, and fixed space delimted formats#38atsyplenkov merged 4 commits intoatsyplenkov:masterfrom
Conversation
|
Thanks for the PR. This addition looks very promising. I will review it later this week. First, I want to create some CI workflow to ensure that new features we are implementing will not crash the extension. |
|
@cursor review |
![cursor[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, please upgrade to Bugbot Pro by visiting the Cursor dashboard. Your first 14 days will be free!
src/parse-table.js
Outdated
| if (type === "string") { | ||
| const values = data.map((row) => row[colIndex]).filter(value => value !== ""); | ||
| const allBool = values.every((value) => utils.isBool(value)); | ||
| const allBool = values.every((value) => value && utils.isBool(value)); |
There was a problem hiding this comment.
Bug: Falsy Values Excluded in Type Detection
The value && utils.isX(value) pattern in type detection incorrectly excludes legitimate falsy values (0, false) from integer and boolean type checks. This also creates an inconsistency for null and undefined values: they are ignored during initial counting but then cause type detection to fail because they are falsy and not filtered out before these checks.
|
Dear @juarezr, many thanks for your contributions! |
2 participants
Changes