Skip to content

UpdateProfile password change has wrong boolean condition #482

@lakhansamani

Description

@lakhansamani

Bug Description

In internal/graphql/update_profile.go:154, the condition !isBasicAuthEnabled || !isMobileBasicAuthEnabled uses OR instead of AND. Password change is blocked if EITHER auth method is disabled, but should only block when BOTH are disabled.

Impact

MEDIUM — Users cannot change their password via UpdateProfile if only one of basic auth or mobile basic auth is enabled.

Fix

Change || to &&: !isBasicAuthEnabled && !isMobileBasicAuthEnabled

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions