Skip to content

VerifyEmail has dead-code loginMethod comparison #484

@lakhansamani

Description

@lakhansamani

Bug Description

In internal/graphql/verify_email.go:137-140, loginMethod is assigned AuthRecipeMethodBasicAuth then immediately compared to VerificationTypeMagicLinkLogin. This condition is always false since these are different constants.

Impact

LOW — Magic link login via VerifyEmail always uses the wrong login method (BasicAuth instead of MagicLinkLogin).

Fix

Check verificationRequest.Identifier instead of loginMethod to determine the verification type.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions