fix: correct verification request expiry logic in Login#492
Merged
lakhansamani merged 4 commits intomainfrom Mar 1, 2026
Merged
fix: correct verification request expiry logic in Login#492lakhansamani merged 4 commits intomainfrom
lakhansamani merged 4 commits intomainfrom
Conversation
The expiry check was inverted - non-expired verification requests were being deleted while expired ones blocked the user. Now non-expired requests correctly return 'email verification pending' and expired ones are deleted and re-sent. Fixes #481
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Fixes #481