Conversation
abdulfatir
approved these changes
Sep 24, 2025
Collaborator
abdulfatir
left a comment
abdulfatir
left a comment
There was a problem hiding this comment.
Looks good. Unrelated to this specific PR, but should we maybe add some tests for the analysis stuff?
src/fev/analysis.py
Outdated
| training_corpus_overlap_df = training_corpus_overlap_df.fillna(False).astype(bool) | ||
| if leakage_imputation_model not in errors_df.columns: | ||
| raise ValueError( | ||
| f"Results for leakage_imputation_model '{leakage_imputation_model}' are missing for some tasks." |
Collaborator
There was a problem hiding this comment.
Is the error message correct? Why some tasks?
Contributor
Author
There was a problem hiding this comment.
Thanks, that was indeed a typo.
Contributor
Author
There was a problem hiding this comment.
Regarding the unit tests: good point, I've added some basic ones for the core analysis methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
leakage_imputation_modelthat replaces errors wheretrained_on_this_dataset==True.win_rateinstead ofskill_scorefor consistency withpairwise_comparison.0.6.1.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.