Skip to content

FIX __eq__ not considering default#232

Merged
mfeurer merged 5 commits intomasterfrom
FIX#214_equality
Feb 8, 2022
Merged

FIX __eq__ not considering default#232
mfeurer merged 5 commits intomasterfrom
FIX#214_equality

Conversation

@KEggensperger
Copy link

also include weights for categoricals

also include weights for categoricals
@KEggensperger KEggensperger requested a review from mfeurer January 31, 2022 16:41
@codecov
Copy link

codecov bot commented Jan 31, 2022

Codecov Report

Merging #232 (2eba68c) into master (5842d4d) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #232      +/-   ##
==========================================
+ Coverage   67.11%   67.15%   +0.04%     
==========================================
  Files          17       17              
  Lines        1627     1629       +2     
==========================================
+ Hits         1092     1094       +2     
  Misses        535      535              
Impacted Files Coverage Δ
ConfigSpace/read_and_write/pcs_new.py 90.93% <0.00%> (+0.02%) ⬆️
ConfigSpace/read_and_write/pcs.py 85.53% <0.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5842d4d...2eba68c. Read the comment docs.

@mfeurer mfeurer self-requested a review February 8, 2022 07:50
Copy link
Author

@KEggensperger KEggensperger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks

Co-authored-by: Katharina Eggensperger <[email protected]>
@mfeurer mfeurer merged commit f1ead4c into master Feb 8, 2022
@mfeurer mfeurer deleted the FIX#214_equality branch February 8, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants