Skip to content

Fix convert count logic.#59

Merged
awcodes merged 1 commit intoawcodes:3.xfrom
slizhva:3.x
Sep 18, 2025
Merged

Fix convert count logic.#59
awcodes merged 1 commit intoawcodes:3.xfrom
slizhva:3.x

Conversation

@slizhva
Copy link
Contributor

@slizhva slizhva commented Sep 16, 2025 •
edited
Loading 

public function convertCount(string|int|float $number): string
{
    if (OverlookPlugin::get()->shouldAbbreviateCount()) { // <== false <== OverlookPlugin::make()->abbreviateCount(false)
        return Number::abbreviate((int) $number);
    }

    return $number; // expected to be string per function definition, but string|int|float returned.
}

@awcodes awcodes merged commit c808d45 into awcodes:3.x Sep 18, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@slizhva @awcodes