fix(http2): avoid including default port in authority string#7256
Merged
DigitalBrainJS merged 2 commits intoaxios:v1.xfrom Dec 19, 2025
Merged
fix(http2): avoid including default port in authority string#7256DigitalBrainJS merged 2 commits intoaxios:v1.xfrom
DigitalBrainJS merged 2 commits intoaxios:v1.xfrom
Conversation
DigitalBrainJS
approved these changes
Dec 18, 2025
This was referenced Jan 25, 2026
This was referenced Feb 9, 2026
|
رقم 7256 |
sgmakgg
added a commit
to boringstudio-org/mcp-gitea
that referenced
this pull request
Mar 13, 2026
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [axios](https://axios-http.com) ([source](https://github.com/axios/axios)) | dependencies | patch | [`1.13.2` → `1.13.4`](https://renovatebot.com/diffs/npm/axios/1.13.2/1.13.4) | --- ### Release Notes <details> <summary>axios/axios (axios)</summary> ### [`v1.13.4`](https://github.com/axios/axios/releases/tag/v1.13.4) [Compare Source](axios/axios@v1.13.3...v1.13.4) #### Overview The release addresses issues discovered in v1.13.3 and includes significant CI/CD improvements. **Full Changelog**: [v1.13.3...v1.13.4](axios/axios@v1.13.3...v1.13.4) #### What's New in v1.13.4 ##### Bug Fixes - **fix: issues with version 1.13.3** ([#​7352](axios/axios#7352)) ([ee90dfc](axios/axios@ee90dfc)) - Fixed issues discovered in v1.13.3 release - Cleaned up interceptor test files - Improved workflow configurations ##### Infrastructure & CI/CD - **refactor: ci and build** ([#​7340](axios/axios#7340)) ([8ff6c19](axios/axios@8ff6c19)) - Major refactoring of CI/CD workflows - Consolidated workflow files for better maintainability - Added mise configuration for the development environment - Improved sponsor block update automation - Enhanced issue and PR templates - Added automatic release notes generation - Implemented workflow cancellation for concurrent runs - **chore: codegen and some updates to workflows** ([76cf77b](axios/axios@76cf77b)) - Code generation improvements - Workflow optimisations #### Migration Notes ##### Breaking Changes None in this release. ##### Deprecations None in this release. #### Contributors Thank you to all contributors who made this release possible! Special thanks to: - [jasonsaayman](https://github.com/jasonsaayman) - Release management and CI/CD improvements ### [`v1.13.3`](https://github.com/axios/axios/blob/HEAD/CHANGELOG.md#1133-2026-01-20) [Compare Source](axios/axios@v1.13.2...v1.13.3) ##### Bug Fixes - **http2:** Use port 443 for HTTPS connections by default. ([#​7256](axios/axios#7256)) ([d7e6065](axios/axios@d7e6065)) - **interceptor:** handle the error in the same interceptor ([#​6269](axios/axios#6269)) ([5945e40](axios/axios@5945e40)) - main field in package.json should correspond to cjs artifacts ([#​5756](axios/axios#5756)) ([7373fbf](axios/axios@7373fbf)) - **package.json:** add 'bun' package.json 'exports' condition. Load the Node.js build in Bun instead of the browser build ([#​5754](axios/axios#5754)) ([b89217e](axios/axios@b89217e)) - silentJSONParsing=false should throw on invalid JSON ([#​7253](axios/axios#7253)) ([#​7257](axios/axios#7257)) ([7d19335](axios/axios@7d19335)) - turn AxiosError into a native error ([#​5394](axios/axios#5394)) ([#​5558](axios/axios#5558)) ([1c6a86d](axios/axios@1c6a86d)) - **types:** add handlers to AxiosInterceptorManager interface ([#​5551](axios/axios#5551)) ([8d1271b](axios/axios@8d1271b)) - **types:** restore AxiosError.cause type from unknown to Error ([#​7327](axios/axios#7327)) ([d8233d9](axios/axios@d8233d9)) - unclear error message is thrown when specifying an empty proxy authorization ([#​6314](axios/axios#6314)) ([6ef867e](axios/axios@6ef867e)) ##### Features - add `undefined` as a value in AxiosRequestConfig ([#​5560](axios/axios#5560)) ([095033c](axios/axios@095033c)) - add automatic minor and patch upgrades to dependabot ([#​6053](axios/axios#6053)) ([65a7584](axios/axios@65a7584)) - add Node.js coverage script using c8 (closes [#​7289](axios/axios#7289)) ([#​7294](axios/axios#7294)) ([ec9d94e](axios/axios@ec9d94e)) - added copilot instructions ([3f83143](axios/axios@3f83143)) - compatibility with frozen prototypes ([#​6265](axios/axios#6265)) ([860e033](axios/axios@860e033)) - enhance pipeFileToResponse with error handling ([#​7169](axios/axios#7169)) ([88d7884](axios/axios@88d7884)) - **types:** Intellisense for string literals in a widened union ([#​6134](axios/axios#6134)) ([f73474d](axios/axios@f73474d)), closes [/github.com/microsoft/TypeScript/issues/33471#issuecomment-1376364329](https://github.com//github.com/microsoft/TypeScript/issues/33471/issues/issuecomment-1376364329) ##### Reverts - Revert "fix: silentJSONParsing=false should throw on invalid JSON ([#​7253](axios/axios#7253)) ([#​7](https://github.com/axios/axios/issues/7)…" ([#​7298](axios/axios#7298)) ([a4230f5](axios/axios@a4230f5)), closes [#​7253](axios/axios#7253) [#​7](axios/axios#7) [#​7298](axios/axios#7298) - **deps:** bump peter-evans/create-pull-request from 7 to 8 in the github-actions group ([#​7334](axios/axios#7334)) ([2d6ad5e](axios/axios@2d6ad5e)) ##### Contributors to this release - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/175160345?v=4&s=18" alt="avatar" width="18"/> [Ashvin Tiwari](https://github.com/ashvin2005 "+1752/-4 (#​7218 #​7218 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/71729144?v=4&s=18" alt="avatar" width="18"/> [Nikunj Mochi](https://github.com/mochinikunj "+940/-12 (#​7294 #​7294 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/128113546?v=4&s=18" alt="avatar" width="18"/> [Anchal Singh](https://github.com/imanchalsingh "+544/-102 (#​7169 #​7185 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/4814473?v=4&s=18" alt="avatar" width="18"/> [jasonsaayman](https://github.com/jasonsaayman "+317/-73 (#​7334 #​7298 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/377911?v=4&s=18" alt="avatar" width="18"/> [Julian Dax](https://github.com/brodo "+99/-120 (#​5558 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/184285082?v=4&s=18" alt="avatar" width="18"/> [Akash Dhar Dubey](https://github.com/AKASHDHARDUBEY "+167/-0 (#​7287 #​7288 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/145687605?v=4&s=18" alt="avatar" width="18"/> [Madhumita](https://github.com/madhumitaaa "+20/-68 (#​7198 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/24915252?v=4&s=18" alt="avatar" width="18"/> [Tackoil](https://github.com/Tackoil "+80/-2 (#​6269 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/145078271?v=4&s=18" alt="avatar" width="18"/> [Justin Dhillon](https://github.com/justindhillon "+41/-41 (#​6324 #​6315 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/184138832?v=4&s=18" alt="avatar" width="18"/> [Rudransh](https://github.com/Rudrxxx "+71/-2 (#​7257 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/146366930?v=4&s=18" alt="avatar" width="18"/> [WuMingDao](https://github.com/WuMingDao "+36/-36 (#​7215 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/46827243?v=4&s=18" alt="avatar" width="18"/> [codenomnom](https://github.com/codenomnom "+70/-0 (#​7201 #​7201 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/189698992?v=4&s=18" alt="avatar" width="18"/> [Nandan Acharya](https://github.com/Nandann018-ux "+60/-10 (#​7272 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/7225168?v=4&s=18" alt="avatar" width="18"/> [Eric Dubé](https://github.com/KernelDeimos "+22/-40 (#​7042 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/915045?v=4&s=18" alt="avatar" width="18"/> [Tibor Pilz](https://github.com/tiborpilz "+40/-4 (#​5551 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/23138717?v=4&s=18" alt="avatar" width="18"/> [Gabriel Quaresma](https://github.com/joaoGabriel55 "+31/-4 (#​6314 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/21505?v=4&s=18" alt="avatar" width="18"/> [Turadg Aleahmad](https://github.com/turadg "+23/-6 (#​6265 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/4273631?v=4&s=18" alt="avatar" width="18"/> [JohnTitor](https://github.com/kiritosan "+14/-14 (#​6155 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/39668736?v=4&s=18" alt="avatar" width="18"/> [rohit miryala](https://github.com/rohitmiryala "+22/-0 (#​7250 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/30316250?v=4&s=18" alt="avatar" width="18"/> [Wilson Mun](https://github.com/wmundev "+20/-0 (#​6053 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/184506226?v=4&s=18" alt="avatar" width="18"/> [techcodie](https://github.com/techcodie "+7/-7 (#​7236 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/187598667?v=4&s=18" alt="avatar" width="18"/> [Ved Vadnere](https://github.com/Archis009 "+5/-6 (#​7283 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/115612815?v=4&s=18" alt="avatar" width="18"/> [svihpinc](https://github.com/svihpinc "+5/-3 (#​6134 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/123884782?v=4&s=18" alt="avatar" width="18"/> [SANDESH LENDVE](https://github.com/mrsandy1965 "+3/-3 (#​7246 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/12529395?v=4&s=18" alt="avatar" width="18"/> [Lubos](https://github.com/mrlubos "+5/-1 (#​7312 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/709451?v=4&s=18" alt="avatar" width="18"/> [Jarred Sumner](https://github.com/Jarred-Sumner "+5/-1 (#​5754 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/17907922?v=4&s=18" alt="avatar" width="18"/> [Adam Hines](https://github.com/thebanjomatic "+2/-1 (#​5756 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/177472603?v=4&s=18" alt="avatar" width="18"/> [Subhan Kumar Rai](https://github.com/Subhan030 "+2/-1 (#​7256 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/6473925?v=4&s=18" alt="avatar" width="18"/> [Joseph Frazier](https://github.com/josephfrazier "+1/-1 (#​7311 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/184906930?v=4&s=18" alt="avatar" width="18"/> [KT0803](https://github.com/KT0803 "+0/-2 (#​7229 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/6703955?v=4&s=18" alt="avatar" width="18"/> [Albie](https://github.com/AlbertoSadoc "+1/-1 (#​5560 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/9452325?v=4&s=18" alt="avatar" width="18"/> [Jake Hayes](https://github.com/thejayhaykid "+1/-0 (#​5999 )") </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi45NC4zIiwidXBkYXRlZEluVmVyIjoiNDIuOTQuMyIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: ChubbChubbs <[email protected]> Reviewed-on: https://git.boringstudio.by/BoringStudio/mcp-gitea/pulls/18 Co-authored-by: boring-bot <[email protected]> Co-committed-by: boring-bot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Remove Default Port From HTTP/2
:authorityHeader (#7249)Problem
Certain HTTP/2 servers reject requests when the
:authorityheader includes a default port value that is already implied by the protocol. Axios previously generated an authority string like:Even when the URL did not explicitly specify a port. Some HTTP/2 implementations expect the header to omit default ports and therefore responded with connection errors or rejected the request because the authority value was considered invalid.
Solution
The logic in
lib/adapters/http.jshas been updated to::authoritywhen it is the protocol default8080,8443)After this change, Axios now generates:
unless a custom port was intentionally provided.
Testing
A regression test has been added to confirm this behavior and ensure long-term consistency.
Impact
This change improves Axios compatibility with strict HTTP/2 servers by aligning the authority header formatting with expected protocol behavior. The update is non-breaking, does not alter API usage, and includes test coverage to prevent future regressions.