Fix issues with version 1.13.3 by jasonsaayman · Pull Request #7352 · axios/axios

jasonsaayman · 2026-01-26T19:26:59Z

This pull request makes several workflow and code changes, primarily focused on simplifying the Axios interceptor chain logic and updating GitHub Actions workflows. The most significant update is a simplification of how Axios handles interceptor promises, which also results in the removal of some related tests. Additionally, the workflows for release and pull request automation have been updated for better maintainability and compatibility.

Axios Interceptor Chain Simplification:

Simplified the promise chaining logic for both request and response interceptors in the Axios class by directly passing both resolve and reject handlers to .then, instead of using .catch and tracking previous results. This makes the code cleaner and easier to follow. [1] [2]
Removed several tests related to error handling in interceptors, as the new chaining logic changes how errors propagate and are handled.

GitHub Actions Workflow Updates:

Updated the release branch workflow to use manual npm version commands for version bumping instead of the phips28/gh-action-bump-version action, and added an explicit git identity configuration step.
Upgraded the peter-evans/create-pull-request action from v7 to v8 in both the release branch and sponsor block update workflows, and adjusted input parameters for improved compatibility and clarity. [1] [2]
Removed the step for creating a GitHub release tag in the publish workflow, streamlining the release process.

Summary by cubic

Simplifies Axios interceptor chaining and streamlines release workflows to fix issues in v1.13.3. This reduces interceptor complexity and makes CI releases more reliable.

Refactors
- Request and response interceptors now use promise.then(resolve, reject) for clearer error propagation.
- Removed interceptor error-handling tests that no longer apply to the new chaining logic.
Bug Fixes
- Switched release versioning to manual npm version with configured git identity.
- Upgraded peter-evans/create-pull-request to v8 and updated inputs.
- Removed GitHub release tag creation from the publish workflow.

^{Written for commit c5b588c. Summary will update on new commits.}

cubic-dev-ai

2 issues found across 5 files

Prompt for AI agents (all issues)


Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name=".github/workflows/release-branch.yml">

<violation number="1" location=".github/workflows/release-branch.yml:50">
P1: The auto version logic is broken. `npm version` without arguments outputs version info (package, npm, node versions), not bump type strings like 'patch', 'minor', or 'major'. The grep will match nothing, causing the workflow to fail when 'auto' is selected. Consider implementing proper version bump detection logic (e.g., using conventional commits or explicit input).</violation>

<violation number="2" location=".github/workflows/release-branch.yml:58">
P2: The `::set-output` syntax is deprecated by GitHub Actions. Use the new `$GITHUB_OUTPUT` environment file approach instead to avoid deprecation warnings and ensure future compatibility.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

.github/workflows/release-branch.yml

Copilot

Pull request overview

This PR simplifies Axios interceptor promise chaining and adjusts GitHub Actions workflows for release automation, sponsor-block updates, and publishing. The main functional impact is on how interceptor errors propagate and on how the release workflow computes and applies new versions.

Changes:

Simplified async request and response interceptor chaining by passing both resolve and reject handlers directly to Promise.then, and removed associated tests whose expectations no longer match the new error-propagation behavior.
Reworked the release-branch workflow to use npm version directly (with a custom auto/beta handling script), updated the release PR creation step, and removed the separate GitHub release tagging step from the publish workflow.
Upgraded peter-evans/create-pull-request to v8 in the release and sponsor-block workflows and kept the sponsor-block automation behavior the same.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
`lib/core/Axios.js`	Adjusts async interceptor promise chaining to use `then(onFulfilled, onRejected)` for both request and response interceptors, changing how errors and values flow through the chain.
`test/specs/interceptors.spec.js`	Removes several interceptor error-handling tests that validated the previous async error-propagation and config-preservation semantics.
`.github/workflows/update-sponsor-block.yml`	Updates the sponsor-block workflow to use `peter-evans/create-pull-request@v8` while otherwise preserving its behavior.
`.github/workflows/release-branch.yml`	Replaces the external bump-version action with an inline `npm version` script, configures git identity, and updates the release PR creation step (including the target branch and action version).
`.github/workflows/publish.yml`	Simplifies the publish workflow by removing the GitHub release-tag creation step, leaving only the NPM publish path.

lib/core/Axios.js

.github/workflows/release-branch.yml

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [axios](https://axios-http.com) ([source](https://github.com/axios/axios)) | dependencies | patch | [`1.13.2` → `1.13.4`](https://renovatebot.com/diffs/npm/axios/1.13.2/1.13.4) | --- ### Release Notes <details> <summary>axios/axios (axios)</summary> ### [`v1.13.4`](https://github.com/axios/axios/releases/tag/v1.13.4) [Compare Source](axios/axios@v1.13.3...v1.13.4) #### Overview The release addresses issues discovered in v1.13.3 and includes significant CI/CD improvements. **Full Changelog**: [v1.13.3...v1.13.4](axios/axios@v1.13.3...v1.13.4) #### What's New in v1.13.4 ##### Bug Fixes - **fix: issues with version 1.13.3** ([#7352](axios/axios#7352)) ([ee90dfc](axios/axios@ee90dfc)) - Fixed issues discovered in v1.13.3 release - Cleaned up interceptor test files - Improved workflow configurations ##### Infrastructure & CI/CD - **refactor: ci and build** ([#7340](axios/axios#7340)) ([8ff6c19](axios/axios@8ff6c19)) - Major refactoring of CI/CD workflows - Consolidated workflow files for better maintainability - Added mise configuration for the development environment - Improved sponsor block update automation - Enhanced issue and PR templates - Added automatic release notes generation - Implemented workflow cancellation for concurrent runs - **chore: codegen and some updates to workflows** ([76cf77b](axios/axios@76cf77b)) - Code generation improvements - Workflow optimisations #### Migration Notes ##### Breaking Changes None in this release. ##### Deprecations None in this release. #### Contributors Thank you to all contributors who made this release possible! Special thanks to: - [jasonsaayman](https://github.com/jasonsaayman) - Release management and CI/CD improvements ### [`v1.13.3`](https://github.com/axios/axios/blob/HEAD/CHANGELOG.md#1133-2026-01-20) [Compare Source](axios/axios@v1.13.2...v1.13.3) ##### Bug Fixes - **http2:** Use port 443 for HTTPS connections by default. ([#7256](axios/axios#7256)) ([d7e6065](axios/axios@d7e6065)) - **interceptor:** handle the error in the same interceptor ([#6269](axios/axios#6269)) ([5945e40](axios/axios@5945e40)) - main field in package.json should correspond to cjs artifacts ([#5756](axios/axios#5756)) ([7373fbf](axios/axios@7373fbf)) - **package.json:** add 'bun' package.json 'exports' condition. Load the Node.js build in Bun instead of the browser build ([#5754](axios/axios#5754)) ([b89217e](axios/axios@b89217e)) - silentJSONParsing=false should throw on invalid JSON ([#7253](axios/axios#7253)) ([#7257](axios/axios#7257)) ([7d19335](axios/axios@7d19335)) - turn AxiosError into a native error ([#5394](axios/axios#5394)) ([#5558](axios/axios#5558)) ([1c6a86d](axios/axios@1c6a86d)) - **types:** add handlers to AxiosInterceptorManager interface ([#5551](axios/axios#5551)) ([8d1271b](axios/axios@8d1271b)) - **types:** restore AxiosError.cause type from unknown to Error ([#7327](axios/axios#7327)) ([d8233d9](axios/axios@d8233d9)) - unclear error message is thrown when specifying an empty proxy authorization ([#6314](axios/axios#6314)) ([6ef867e](axios/axios@6ef867e)) ##### Features - add `undefined` as a value in AxiosRequestConfig ([#5560](axios/axios#5560)) ([095033c](axios/axios@095033c)) - add automatic minor and patch upgrades to dependabot ([#6053](axios/axios#6053)) ([65a7584](axios/axios@65a7584)) - add Node.js coverage script using c8 (closes [#7289](axios/axios#7289)) ([#7294](axios/axios#7294)) ([ec9d94e](axios/axios@ec9d94e)) - added copilot instructions ([3f83143](axios/axios@3f83143)) - compatibility with frozen prototypes ([#6265](axios/axios#6265)) ([860e033](axios/axios@860e033)) - enhance pipeFileToResponse with error handling ([#7169](axios/axios#7169)) ([88d7884](axios/axios@88d7884)) - **types:** Intellisense for string literals in a widened union ([#6134](axios/axios#6134)) ([f73474d](axios/axios@f73474d)), closes [/github.com/microsoft/TypeScript/issues/33471#issuecomment-1376364329](https://github.com//github.com/microsoft/TypeScript/issues/33471/issues/issuecomment-1376364329) ##### Reverts - Revert "fix: silentJSONParsing=false should throw on invalid JSON ([#7253](axios/axios#7253)) ([#7](https://github.com/axios/axios/issues/7)…" ([#7298](axios/axios#7298)) ([a4230f5](axios/axios@a4230f5)), closes [#7253](axios/axios#7253) [#7](axios/axios#7) [#7298](axios/axios#7298) - **deps:** bump peter-evans/create-pull-request from 7 to 8 in the github-actions group ([#7334](axios/axios#7334)) ([2d6ad5e](axios/axios@2d6ad5e)) ##### Contributors to this release - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/175160345?v=4&s=18" alt="avatar" width="18"/> [Ashvin Tiwari](https://github.com/ashvin2005 "+1752/-4 (#7218 #7218 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/71729144?v=4&s=18" alt="avatar" width="18"/> [Nikunj Mochi](https://github.com/mochinikunj "+940/-12 (#7294 #7294 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/128113546?v=4&s=18" alt="avatar" width="18"/> [Anchal Singh](https://github.com/imanchalsingh "+544/-102 (#7169 #7185 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/4814473?v=4&s=18" alt="avatar" width="18"/> [jasonsaayman](https://github.com/jasonsaayman "+317/-73 (#7334 #7298 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/377911?v=4&s=18" alt="avatar" width="18"/> [Julian Dax](https://github.com/brodo "+99/-120 (#5558 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/184285082?v=4&s=18" alt="avatar" width="18"/> [Akash Dhar Dubey](https://github.com/AKASHDHARDUBEY "+167/-0 (#7287 #7288 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/145687605?v=4&s=18" alt="avatar" width="18"/> [Madhumita](https://github.com/madhumitaaa "+20/-68 (#7198 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/24915252?v=4&s=18" alt="avatar" width="18"/> [Tackoil](https://github.com/Tackoil "+80/-2 (#6269 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/145078271?v=4&s=18" alt="avatar" width="18"/> [Justin Dhillon](https://github.com/justindhillon "+41/-41 (#6324 #6315 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/184138832?v=4&s=18" alt="avatar" width="18"/> [Rudransh](https://github.com/Rudrxxx "+71/-2 (#7257 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/146366930?v=4&s=18" alt="avatar" width="18"/> [WuMingDao](https://github.com/WuMingDao "+36/-36 (#7215 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/46827243?v=4&s=18" alt="avatar" width="18"/> [codenomnom](https://github.com/codenomnom "+70/-0 (#7201 #7201 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/189698992?v=4&s=18" alt="avatar" width="18"/> [Nandan Acharya](https://github.com/Nandann018-ux "+60/-10 (#7272 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/7225168?v=4&s=18" alt="avatar" width="18"/> [Eric Dubé](https://github.com/KernelDeimos "+22/-40 (#7042 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/915045?v=4&s=18" alt="avatar" width="18"/> [Tibor Pilz](https://github.com/tiborpilz "+40/-4 (#5551 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/23138717?v=4&s=18" alt="avatar" width="18"/> [Gabriel Quaresma](https://github.com/joaoGabriel55 "+31/-4 (#6314 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/21505?v=4&s=18" alt="avatar" width="18"/> [Turadg Aleahmad](https://github.com/turadg "+23/-6 (#6265 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/4273631?v=4&s=18" alt="avatar" width="18"/> [JohnTitor](https://github.com/kiritosan "+14/-14 (#6155 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/39668736?v=4&s=18" alt="avatar" width="18"/> [rohit miryala](https://github.com/rohitmiryala "+22/-0 (#7250 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/30316250?v=4&s=18" alt="avatar" width="18"/> [Wilson Mun](https://github.com/wmundev "+20/-0 (#6053 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/184506226?v=4&s=18" alt="avatar" width="18"/> [techcodie](https://github.com/techcodie "+7/-7 (#7236 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/187598667?v=4&s=18" alt="avatar" width="18"/> [Ved Vadnere](https://github.com/Archis009 "+5/-6 (#7283 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/115612815?v=4&s=18" alt="avatar" width="18"/> [svihpinc](https://github.com/svihpinc "+5/-3 (#6134 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/123884782?v=4&s=18" alt="avatar" width="18"/> [SANDESH LENDVE](https://github.com/mrsandy1965 "+3/-3 (#7246 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/12529395?v=4&s=18" alt="avatar" width="18"/> [Lubos](https://github.com/mrlubos "+5/-1 (#7312 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/709451?v=4&s=18" alt="avatar" width="18"/> [Jarred Sumner](https://github.com/Jarred-Sumner "+5/-1 (#5754 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/17907922?v=4&s=18" alt="avatar" width="18"/> [Adam Hines](https://github.com/thebanjomatic "+2/-1 (#5756 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/177472603?v=4&s=18" alt="avatar" width="18"/> [Subhan Kumar Rai](https://github.com/Subhan030 "+2/-1 (#7256 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/6473925?v=4&s=18" alt="avatar" width="18"/> [Joseph Frazier](https://github.com/josephfrazier "+1/-1 (#7311 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/184906930?v=4&s=18" alt="avatar" width="18"/> [KT0803](https://github.com/KT0803 "+0/-2 (#7229 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/6703955?v=4&s=18" alt="avatar" width="18"/> [Albie](https://github.com/AlbertoSadoc "+1/-1 (#5560 )") - <img src="proxy.php?url=https://avatars.githubusercontent.com/u/9452325?v=4&s=18" alt="avatar" width="18"/> [Jake Hayes](https://github.com/thejayhaykid "+1/-0 (#5999 )") </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: ChubbChubbs <[email protected]> Reviewed-on: https://git.boringstudio.by/BoringStudio/mcp-gitea/pulls/18 Co-authored-by: boring-bot <[email protected]> Co-committed-by: boring-bot <[email protected]>

fix: issues with version 1.13.3

c5b588c

jasonsaayman self-assigned this Jan 26, 2026

jasonsaayman added the priority::medium A medium priority label Jan 26, 2026

Copilot AI review requested due to automatic review settings January 26, 2026 19:27

jasonsaayman added commit::fix The PR is related to a bugfix commit::ci The PR is related to CI labels Jan 26, 2026

Copilot started reviewing on behalf of jasonsaayman January 26, 2026 19:27 View session

cubic-dev-ai bot reviewed Jan 26, 2026

View reviewed changes

.github/workflows/release-branch.yml Show resolved Hide resolved

.github/workflows/release-branch.yml Show resolved Hide resolved

Copilot AI reviewed Jan 26, 2026

View reviewed changes

lib/core/Axios.js Show resolved Hide resolved

.github/workflows/release-branch.yml Show resolved Hide resolved

.github/workflows/release-branch.yml Show resolved Hide resolved

Copilot AI reviewed Jan 26, 2026

View reviewed changes

jasonsaayman merged commit ee90dfc into v1.x Jan 27, 2026
15 checks passed

jasonsaayman deleted the fix-release-issues branch January 27, 2026 06:04

ccastrotrejo mentioned this pull request Feb 18, 2026

chore(deps): bump axios from 1.12.1 to 1.13.5 Azure/LogicAppsUX#8800

Merged

14 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix issues with version 1.13.3#7352

Fix issues with version 1.13.3#7352
jasonsaayman merged 1 commit intov1.xfrom
fix-release-issues

jasonsaayman commented Jan 26, 2026 •

edited by cubic-dev-ai bot

Loading

Uh oh!

cubic-dev-ai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

jasonsaayman commented Jan 26, 2026 • edited by cubic-dev-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by cubic

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jasonsaayman commented Jan 26, 2026 •

edited by cubic-dev-ai bot

Loading