docs: fix typos#15432
Conversation
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/53960/ |
|
Thanks, looks great overall! Except for a few places that we can't fix right now due to compatibility. |
| // TODO: Accesor -> Accessor | ||
| SetAccesorCannotHaveOptionalParameter: | ||
| // TODO: Accessor -> Accessor | ||
| SetAccessorCannotHaveOptionalParameter: |
There was a problem hiding this comment.
These error codes are public and we had to postpone the fix. :)
…OptionalParameter
Co-authored-by: Huáng Jùnliàng <[email protected]>
Co-authored-by: Huáng Jùnliàng <[email protected]>
|
How do I fix CI? |
This looks like a random network error, don't bother with it. packages/babel-parser/src/plugins/typescript/index.ts The error codes in both files are public and we cannot modify them for now. |
|
I changed the typescript file in c7be4ab, I'll do the flow one now :) thanks |
|
Unfortunately all error codes are public and we need to restore them (besides two other comments in the file) |
|
Sorry, I didn't notice the other error code changes in the typescript file. |
|
It doesn't matter. Everything looks great now! Thanks a lot for your contribution! |
github-actions
bot
added
the
outdated
5 participants
This PR fixes some typos throughout the repository (this was a trial run for a CLI I made). I'm unfamiliar with this codebase, so if I made any breaking changes that need to be reverted, or if you want me to split this into multiple prs, or anything else please let me know!