fix: make the pythons_hub platform independent#1946
Merged
aignas merged 2 commits intobazel-contrib:mainfrom Jun 10, 2024
Merged
fix: make the pythons_hub platform independent#1946aignas merged 2 commits intobazel-contrib:mainfrom
aignas merged 2 commits intobazel-contrib:mainfrom
Conversation
With this change we can finally have platform independent bzlmod lock files in rules_python. This cleans up code paths that were not being used in the `pip` extension for a while and the replacement is noted in the CHANGELOG. Fixes bazel-contrib#1643
Collaborator
Author
|
Thanks to @fmeum for the really fast response. |
groodt
approved these changes
Jun 10, 2024
Collaborator
groodt
left a comment
groodt
left a comment
There was a problem hiding this comment.
LGTM
I actually needed something like python_{version}_host recently.
aignas
commented
Jun 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change we can finally have platform independent bzlmod lock
files in rules_python. This cleans up code paths that were not being
used in the
pipextension for a while and the replacement is noted inthe CHANGELOG.
Fixes #1643