fix: Add libdir to library search path#2476
Merged
aignas merged 4 commits intobazel-contrib:mainfrom Mar 7, 2025
Merged
Conversation
aignas
reviewed
Dec 7, 2024
Collaborator
aignas
left a comment
aignas
left a comment
There was a problem hiding this comment.
Because this is gated by a feature toggle, it seems to be low risk to include.
Collaborator
|
Just want to respond to something the comment says: It's not possible to reliably get the correct Python interpreter. This is because the repo phase doesn't know, and can't know, what the build phase is going to do (i.e. what python interpreter will be used). The basic change in this PR is somewhat an improvement, but yeah -- just wanted to point out it'll still be prone to issues. To really fix this, the sdist building needs to move into the build phase. |
Collaborator
|
I'll add some ideas about this in #2410. |
Contributor
Author
|
Is there anything else you'd like me to do for this PR? |
aignas
approved these changes
Mar 7, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We discovered when dealing with libraries such as
psycopg2that the wheel would attempt to link againstlibpython.a. This fix points the linker at the correct python version being used.