fix(sphinxdocs): do not crash when tag_class does not have doc#2585
Merged
rickeylev merged 1 commit intobazel-contrib:mainfrom Jan 26, 2025
Merged
fix(sphinxdocs): do not crash when tag_class does not have doc#2585rickeylev merged 1 commit intobazel-contrib:mainfrom
rickeylev merged 1 commit intobazel-contrib:mainfrom
Conversation
It seems that there was a typo in the code and instead of calling `self._write` we were calling `self.write`. It went unnoticed because of lack of coverage. This adds test code exercising the edge case and fixes the typo. Fixes bazel-contrib#2579
rickeylev
approved these changes
Jan 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that there was a typo in the code and instead of calling
self._writewe were callingself.write. It went unnoticed because oflack of coverage. This adds test code exercising the edge case and fixes
the typo.
Fixes #2579