feat: Package pyi files in wheel#2609
Merged
aignas merged 7 commits intobazel-contrib:mainfrom Mar 6, 2025
Merged
Conversation
aignas
reviewed
Feb 13, 2025
Collaborator
aignas
left a comment
aignas
left a comment
There was a problem hiding this comment.
Could you please add a test to examples/wheel folder showing that the files get packaged?
1.1.0 introduced separate attributes for the type definitions (`.pyi` files) and type checking. This patch adds those files to the wheel to ensure that they are distributed and available to users.
1.1.0 introduced separate attributes for the type definitions (`.pyi` files) and type checking. This patch adds those files to the package produced by `py_package` and updates the wheel examples.
Synss
force-pushed
the
package-pyi-in-py_wheel
branch
from
5fa7a3f to
70a5a65
Compare
Contributor
Author
Done. I also had to propagate the |
aignas
reviewed
Feb 27, 2025
Collaborator
aignas
left a comment
aignas
left a comment
There was a problem hiding this comment.
In general LGTM, thank you for the added tests. Only minor nits to address before merging.
Thank you for your contribution.
Collaborator
|
Could you please fix the failing tests? |
Checksums became out of sync.
Contributor
Author
|
Done in f3ce381 if I didn't overlook anything this time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.1.0 introduced separate attributes for the type definitions (
.pyifiles) and type checking. This patch adds those files to the wheel to ensure that they are distributed and available to users.#2538 introduced
pyi_srcs.