refactor: cleanup now-unreferenced proto toolchain type#2620
refactor: cleanup now-unreferenced proto toolchain type#2620rickeylev merged 4 commits intobazel-contrib:mainfrom
Conversation
|
Sure - @aignas to move things along faster please feel free to just click the "pencil" icon and make trivial edits like that as your own commits on my PR 😉 |
|
I added the deprecation attr setting. It's annoying that the toolchain type is under a "private" directory. They should give a public access point for it. Queued for merge. I'll cherry pick this into the 1.2 release. |
I do it when I can and when I have my laptop with me. I am not doing it now not because I don't know how to or am unwilling, so no need to point it out. :) In other words, everybody does as much as they can. :) |
Follow-up to #2604, fixes a breaking change in v1.2.0-rc0 Note that this toolchain_type became unused in that PR. We leave behind an alias to make this a non-breaking change. Verified in a downstream repo that requires the toolchain_type to register pre-built `protoc`: https://github.com/aspect-build/toolchains_protoc/pull/50/files --------- Co-authored-by: Richard Levasseur <[email protected]> (cherry picked from commit f9779ee)
3 participants
Follow-up to #2604, fixes a breaking change in v1.2.0-rc0
Note that this toolchain_type became unused in that PR. We leave behind an alias to make this a non-breaking change.
Verified in a downstream repo that requires the toolchain_type to register pre-built
protoc: https://github.com/aspect-build/toolchains_protoc/pull/50/files