ci: use Python 3.9 for mypy workflow to fix ci#2625
Merged
rickeylev merged 2 commits intobazel-contrib:mainfrom Feb 24, 2025
Merged
ci: use Python 3.9 for mypy workflow to fix ci#2625rickeylev merged 2 commits intobazel-contrib:mainfrom
rickeylev merged 2 commits intobazel-contrib:mainfrom
Conversation
rickeylev
changed the title
aignas
approved these changes
Feb 24, 2025
Collaborator
|
One thing to note here is that we might break the type annotations for earlier python versions more easily if we are testing on 3.11 only. We may want to either use the previous version of GH action that is using an older mypy version instead of bumping to 3.11. That said the new style type annotations have been here for a while, so maybe just using 3.11 is a good enough thing, but maybe the oldest supported python version would be better. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 24, 2025
The mypy check on CI has been failing. The problem was the combination of: * We were using Python 3.8 * jpetrucciani/mypy-check@master updated to use mypy 1.15 * mypy 1.15 dropped support for Python 3.8 To fix, use Python 3.11.
rickeylev
changed the title
Collaborator
Author
|
Good point. Updated to 3.9. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mypy check on CI has been failing. The problem was the combination of:
To fix, use Python 3.9.