feat(pypi): support direct urls for wheels in bazel downloader#2655
Merged
aignas merged 13 commits intobazel-contrib:mainfrom Mar 12, 2025
Merged
feat(pypi): support direct urls for wheels in bazel downloader#2655aignas merged 13 commits intobazel-contrib:mainfrom
aignas merged 13 commits intobazel-contrib:mainfrom
Conversation
todo: check later if filename is necessary. Maybe not.
chrisirhc
changed the title
chrisirhc
changed the title
chrisirhc
changed the title
chrisirhc
changed the title
chrisirhc
changed the title
Collaborator
|
Thank you for the contribution.
I think this part might be good to leave for another PR. |
aignas
requested changes
Mar 10, 2025
Collaborator
aignas
left a comment
aignas
left a comment
There was a problem hiding this comment.
LGTM in general, I think we can correctly infer the sdist vs not via the direct URLs, so I think its fine to just do it.
Could you please also add the CHANGELOG note about the added support.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for installing wheels via direct urls in the requirements lock file:
This is to improve parity between bazel downloader and pip behavior.
Before this change, direct urls used fallback to pip install.
Partially addresses #2363 as it does not add support for git urls.