chore(deps): bump rules_cc to 0.1.5#3238
Merged
aignas merged 1 commit intobazel-contrib:mainfrom Sep 5, 2025
Merged
Conversation
rickeylev
approved these changes
Sep 4, 2025
Collaborator
|
CI gave an error saying gazelle/docs wasn't defined because it's considered deleted. I think the bazelrc update is causing that? In any case, approved so it can be merged when ready. |
34bd76e to
36a2123
Compare
Collaborator
Author
|
Somehow the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue compiling protobuf on windows due to c++ 17 support.
In particular, it gets the fix in
bazelbuild/rules_cc@c7e5c8c
which adds
/std:c++17for Window builds.Fixes #3122