feat: allow setting custom environment variables on pip_repository and whl_library#460
Conversation
mattem
force-pushed
the
feat/environment_attr
branch
from
1c5b79a to
37ca320
Compare
|
cc @alexeagle 🌮 |
mattem
force-pushed
the
feat/environment_attr
branch
from
37ca320 to
40f1a9c
Compare
There was a problem hiding this comment.
In order for this to work with pip_parse the rctx.attr.environment needs to be serialized,see _parse_optional_attrs, and passed into the parse_requirements_to_bzl script via a command line arg. It should then be deserialized and written to the requirements.bzl file that is produced by that script. That will make all the whl_library sub-repos that depend on a pip_parse repo use the environment.
of starlark. * Refactor shared functions between extract_wheel and extract_single_wheel. * Every structured arg now has the same level key when serialized. fixes bazel-contrib#490 * test for pip_data_exclude in arguments parsing test.
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
|
|
@googlebot I consent. |
hrfuller
requested review from
thundergolfer
and removed request for
brandjon and
lberki
|
Hey @mattem I have tested this using an HTTPS_PROXY env var in the pip_parse example, and it works. Would you like to wait for review from @andyscott / @alexeagle before I merge? |
|
Thanks for pushing this over the line @hrfuller! I think this is okay, I'm happy for it to be merged though. |
3 participants
Allows specifying custom environment variables on the pip_repository and whl_library repository rules that are set when run.
Edit: @hrfuller Also incidentally fixes #490