Closed
Conversation
github-actions
bot
added
the
awaiting-review
meteorcloudy
force-pushed
the
bzlmod_by_default
branch
6 times, most recently
from
019e7ba to
3f84a7e
Compare
github-actions
bot
removed
the
awaiting-review
meteorcloudy
force-pushed
the
bzlmod_by_default
branch
6 times, most recently
from
c0fad89 to
8456291
Compare
meteorcloudy
force-pushed
the
bzlmod_by_default
branch
10 times, most recently
from
f389962 to
f2378ce
Compare
meteorcloudy
force-pushed
the
bzlmod_by_default
branch
2 times, most recently
from
26cae5c to
4e46ee3
Compare
meteorcloudy
force-pushed
the
bzlmod_by_default
branch
2 times, most recently
from
1627e1d to
be0dcde
Compare
Avoid hard code rules_cc canonical repo name Update lockfile Fix workspace_resolved_test and test_repo cache Fix naming Fixes Fetch test repos concurrently Reuse repository cache Fix windows Fix rules_cc path Don't use hard link for repo cache inside tests The flag is causing "Invalid cross-device link" error for some reason Revert shard for macos_arm64 Update rules_python to match Bzlmod Update bazel_skylib to match Bzlmod Add bazel_skylib in workspace suffix (required by rules_python since 0.22.0) Fix bazel_determinism_test Update protobuf url to match Bzlmod Update rules_pkg to match bazel_determinism_test: use default repo cache Allow rules_proto tests to access internet declare local_config_cc Disable windows_arm64 temporarily Refactor CI flags Don't use /Users/pcloudy in bazelrc Revert "Disable windows_arm64 temporarily" This reverts commit cba92fd. Fix bazel_sandboxing_networking_test Polish MODULE.bazel pkg_tar: use strip_prefix properly Update lockfile Use --experimental_downloader_config to improve stability Add the original URL as well Polish Polish more
meteorcloudy
force-pushed
the
bzlmod_by_default
branch
from
be0dcde to
33bcfa1
Compare
meteorcloudy
force-pushed
the
bzlmod_by_default
branch
3 times, most recently
from
e47d129 to
72f4a3a
Compare
github-actions
bot
added
awaiting-review
meisterT
reviewed
Sep 6, 2023
| android_ndk_repository/android_ndk_repository/' WORKSPACE | ||
| - rm -f WORKSPACE.bak | ||
| android_ndk_repository/android_ndk_repository/' WORKSPACE.bzlmod | ||
| - rm -f WORKSPACE.bzlmod.bak |
Member
There was a problem hiding this comment.
why are we creating this .bak in the first place if we delete it right away?
Member
Author
There was a problem hiding this comment.
It's just for compatibility with macOS, where sed doesn't support in-place replacing without a .bak file.
Member
There was a problem hiding this comment.
I know this is nitpicking (so feel free to leave as is), but why not do this weird pattern only on Mac?
Member
Author
There was a problem hiding this comment.
I didn't know the original reason, but I guess it's just easier to keep them the same so you can search and edit all places just one time when you need some changes. We can clean this up in another PR if necessary.
meteorcloudy
force-pushed
the
bzlmod_by_default
branch
from
32752df to
e070a9b
Compare
Member
Author
|
I'm importing this PR as a CL to review, just in case it needs some tweak internally. |
github-actions
bot
removed
the
awaiting-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables Bzlmod as the default external dependencies system for Bazel.
Changes included:
.bazelrc.io_bazelto_mainat necessary locations.MODULE.bazel.lock. We should enable--lockfile_mode=erroron CI and--lockfile_mode=updatefor local builds after fixing some issues in the lock file feature, probably with 6.4.0.--override_repositoryhack with repository cache (http artifact cache) for running integration tests without network access. This will eventually be replaced by a true shared repository cache.--experimental_repository_cache_hardlinksinside integration test to avoidinvalid cross-device link. Because the file system of the sandbox dir is different from the repo cache dir.Next step:
Fixes #18957