Print Passed and Failed methods in detailed test summary#19099
Closed
NelsonLi0701 wants to merge 11 commits intobazelbuild:masterfrom
Closed
Print Passed and Failed methods in detailed test summary#19099NelsonLi0701 wants to merge 11 commits intobazelbuild:masterfrom
NelsonLi0701 wants to merge 11 commits intobazelbuild:masterfrom
Conversation
Previously, Bazel only printed Failed methods in the detailed test summary when using the `--test_summary=detailed` option. With this change, both Passed and Failed methods are now printed, providing a more comprehensive view of the test results. Fix bazelbuild#18685
github-actions
bot
added
the
awaiting-review
Pavank1992
added
the
team-Core
jin
reviewed
Jul 28, 2023
Member
jin
left a comment
jin
left a comment
There was a problem hiding this comment.
Please also add an integration test like this: https://cs.opensource.google/bazel/bazel/+/master:src/test/shell/bazel/bazel_test_test.sh;l=652-663;drc=ecf9b9a82aa231cd1fa9178dd9ab64dd67adaf25
src/test/java/com/google/devtools/build/lib/runtime/TestSummaryTest.java
Show resolved
Hide resolved
Previously, Bazel only printed Failed methods in the detailed test summary when using the `--test_summary=detailed` option. With this change, both Passed and Failed methods are now printed, providing a more comprehensive view of the test results. Fix bazelbuild#18685
NelsonLi0701
force-pushed
the
print_passed_methods
branch
from
dfda50c to
3dc1e81
Compare
Contributor
Author
Added |
jin
approved these changes
Jul 28, 2023
jin
added
awaiting-PR-merge
Member
|
According to Bazel PR import instructions, I'll let the gTech team handle the PR import. |
Previously, Bazel only printed Failed methods in the detailed test summary when using the `--test_summary=detailed` option. With this change, both Passed and Failed methods are now printed, providing a more comprehensive view of the test results. Fix bazelbuild#18685
Previously, Bazel only printed Failed methods in the detailed test summary when using the `--test_summary=detailed` option. With this change, both Passed and Failed methods are now printed, providing a more comprehensive view of the test results. Fix bazelbuild#18685
Previously, Bazel only printed Failed methods in the detailed test summary when using the `--test_summary=detailed` option. With this change, both Passed and Failed methods are now printed, providing a more comprehensive view of the test results. Fix bazelbuild#18685
Previously, Bazel only printed Failed methods in the detailed test summary when using the `--test_summary=detailed` option. With this change, both Passed and Failed methods are now printed, providing a more comprehensive view of the test results. Fix bazelbuild#18685
github-actions
bot
removed
the
awaiting-PR-merge
Member
|
Congrats on your first PR to Bazel, Nelson! |
thirtyseven
pushed a commit
to thirtyseven/bazel
that referenced
this pull request
Sep 13, 2023
Previously, Bazel only printed Failed methods in the detailed test summary when using the `--test_summary=detailed` option. With this change, both Passed and Failed methods are now printed, providing a more comprehensive view of the test results. Fix bazelbuild#18685 Closes bazelbuild#19099. RELNOTES: The `--test_summary=detailed` option now also prints passed test cases. PiperOrigin-RevId: 553737487 Change-Id: I332b70d916394de7caed7a07667b46087724a6c1
iancha1992
pushed a commit
that referenced
this pull request
Sep 13, 2023
) Cherry-pick of c75fda9 Previously, Bazel only printed Failed methods in the detailed test summary when using the `--test_summary=detailed` option. With this change, both Passed and Failed methods are now printed, providing a more comprehensive view of the test results. Fix #18685 Closes #19099. RELNOTES: The `--test_summary=detailed` option now also prints passed test cases. PiperOrigin-RevId: 553737487 Change-Id: I332b70d916394de7caed7a07667b46087724a6c1 Co-authored-by: NelsonLi0701 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, Bazel only printed Failed methods in the detailed test summary when using the
--test_summary=detailedoption. With this change, both Passed and Failed methods are now printed, providing a more comprehensive view of the test results.Fix #18685
RELNOTES: The
--test_summary=detailedoption now also prints passed test cases.