Do not rerun module extensions when only imports or locations change#19253
Closed
fmeum wants to merge 2 commits intobazelbuild:masterfrom
Closed
Do not rerun module extensions when only imports or locations change#19253fmeum wants to merge 2 commits intobazelbuild:masterfrom
fmeum wants to merge 2 commits intobazelbuild:masterfrom
Conversation
When using the lockfile, extension evaluation results are now persisted even if the imports (`use_repo`s) fail validation against the actually generated repos and reused if only imports or Starlark locations change. This requires storing `ModuleExtensionMetadata` in the lockfile to ensure that the correct fixup warnings are shown if imports are updated but the extension isn't rerun.
github-actions
bot
added
awaiting-review
Wyverald
reviewed
Aug 15, 2023
Member
Wyverald
left a comment
Wyverald
left a comment
There was a problem hiding this comment.
overall looks great. thank you for the prompt PR!
src/main/java/com/google/devtools/build/lib/bazel/bzlmod/SingleExtensionEvalFunction.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/bazel/bzlmod/SingleExtensionEvalFunction.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/bazel/bzlmod/SingleExtensionEvalFunction.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/bazel/bzlmod/SingleExtensionEvalFunction.java
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/bazel/bzlmod/SingleExtensionEvalFunction.java
Outdated
Show resolved
Hide resolved
Wyverald
approved these changes
Aug 16, 2023
fmeum
force-pushed
the
persist-module-extension-metadata
branch
from
8af9d6e to
1614884
Compare
Wyverald
added
awaiting-PR-merge
github-actions
bot
removed
the
awaiting-PR-merge
Collaborator
Author
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
Member
|
@bazel-io fork 6.4.0 |
bazel-io
removed
the
potential release blocker
iancha1992
pushed a commit
to iancha1992/bazel
that referenced
this pull request
Aug 18, 2023
When using the lockfile, extension evaluation results are now persisted even if the imports (`use_repo`s) fail validation against the actually generated repos and reused if only imports or Starlark locations change. This requires storing `ModuleExtensionMetadata` in the lockfile to ensure that the correct fixup warnings are shown if imports are updated but the extension isn't rerun. Closes bazelbuild#19253. PiperOrigin-RevId: 557878432 Change-Id: I25909294b118fb445f9c48f61e18463762f78208
iancha1992
added a commit
that referenced
this pull request
Aug 22, 2023
… change (#19284) When using the lockfile, extension evaluation results are now persisted even if the imports (`use_repo`s) fail validation against the actually generated repos and reused if only imports or Starlark locations change. This requires storing `ModuleExtensionMetadata` in the lockfile to ensure that the correct fixup warnings are shown if imports are updated but the extension isn't rerun. Closes #19253. Commit 2c2b07b PiperOrigin-RevId: 557878432 Change-Id: I25909294b118fb445f9c48f61e18463762f78208 Co-authored-by: Fabian Meumertzheim <[email protected]>
Member
|
The changes in this PR have been included in Bazel 6.4.0 RC1. Please test out the release candidate and report any issues as soon as possible. If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=last_rc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the lockfile, extension evaluation results are now persisted even if the imports (
use_repos) fail validation against the actually generated repos and reused if only imports or Starlark locations change.This requires storing
ModuleExtensionMetadatain the lockfile to ensure that the correct fixup warnings are shown if imports are updated but the extension isn't rerun.