Conversation
This is a squashed version of PR bazelbuild#3712 bazelbuild#3712 by Jerry Marino <[email protected]> It adds an objc_library option called flatten_virtual_headers that modifies the behavior of include_prefix such that instead of prepending the path to the header's actual path, the headers are mapped to the include_path namespace. E.g. src/heaaders/foo/bar.h src/headers/bar/baz.h with the options: include_prefix = "FOO" flatten_virtual_headers = True would let you include bar.h and baz.h as #include <FOO/bar.h> #include <FOO/baz.h>
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
|
@jerrymarino, I think you need to confirm you're okay contributing my rebased commit to make the @googlebot happy. |
|
@ob wow - great to see this updated. I'm not sure how to verify author consent - cc @googlebot |
Also switch directHeaderMaps to an Artifact list... I'm not even sure directHeaderMaps is needed at all... ;-/
|
Hi Oscar, I'm sorry for the radio silence, there's nothing I can say in my defense. I'll take a thorough look first thing in the morning. |
|
No worries. The PR is still incomplete and I got distracted for a week. The design doc has some open questions and I also have a few implementation questions if you have the bandwidth. I’ll also be on Google Hangouts chat. Thank you for looking at this. |
|
This is no longer being pursued in this form |
4 participants
NOT READY, DO NOT MERGE
I've been playing with #3712 and as a first pass rebased it on top of a current master and incorporated all the feedback given in that PR. I also added an integration test.
I need to add a way to expose the generated header map files to skylark so that other rules (e.g.
swift_library) can use the header maps, but I thought I'd post this here since #3712 seemed pretty close as it was.Design Document