Skip to content

chore(deps): upgrade skylib to remove warnings#1005

Merged
cgrindel merged 1 commit intobazelbuild:mainfrom
rdesgroppes:upgrade-skylib-to-eliminate-deprecation-warnings
Jan 24, 2026
Merged

chore(deps): upgrade skylib to remove warnings#1005
cgrindel merged 1 commit intobazelbuild:mainfrom
rdesgroppes:upgrade-skylib-to-eliminate-deprecation-warnings

Conversation

@rdesgroppes
Copy link
Contributor

@rdesgroppes rdesgroppes commented Jan 20, 2026

This upgrade of bazel_skylib from version 1.7.1 to 1.9.0 eliminates a few deprecation warnings when executing Bazel commands:

WARNING: [...]: target '[...]' depends on deprecated target '@@bazel_tools//src/conditions:host_windows_x64_constraint': No longer used by Bazel and will be removed in the future. Migrate to toolchains or define your own version of this setting.

These warnings originated from bazel_skylib 1.7.1's use of the deprecated @bazel_tools//src/conditions:host_windows constraint in copy_file and diff_test rules.
Since version 1.8.0, bazel_skylib migrated away from this deprecated constraint (see bazelbuild/bazel-skylib#574).

This upgrade of `bazel_skylib` from version 1.7.1 to 1.9.0 eliminates
a few deprecation warnings when executing Bazel commands:
> WARNING: [...]: target '[...]' depends on deprecated target
> '@@bazel_tools//src/conditions:host_windows_x64_constraint': No longer
> used by Bazel and will be removed in the future. Migrate to toolchains
> or define your own version of this setting.

These warnings originated from `bazel_skylib` 1.7.1's use of the
deprecated `@bazel_tools//src/conditions:host_windows` constraint in
`copy_file` and `diff_test rules`.
Since version 1.8.0, `bazel_skylib` migrated away from this deprecated
constraint (see bazelbuild/bazel-skylib#574).
@rdesgroppes rdesgroppes force-pushed the upgrade-skylib-to-eliminate-deprecation-warnings branch from 7caaf5e to efa9e39 Compare January 20, 2026 08:21
@cgrindel
Copy link
Collaborator

Thank you!

@cgrindel cgrindel merged commit 8267e22 into bazelbuild:main Jan 24, 2026
6 checks passed
@rdesgroppes rdesgroppes deleted the upgrade-skylib-to-eliminate-deprecation-warnings branch January 24, 2026 23:25
rdesgroppes added a commit to DataDog/datadog-agent that referenced this pull request Feb 6, 2026
### What does this PR do?
Bump `rules_pkg` from archived release 1.2.0 to current `main` branch to
benefit from recent bugfixes.

### Motivation
The `main` branch includes unreleased fixes:
- Bazel 9 compatibility - when we feel ready to switch to it,
- enhanced RPM support so that it's now possible to build RPMs from
  within Ubuntu CI containers, also with debuginfo:
  bazelbuild/rules_pkg#1006
- dependency on a deprecated target:
  bazelbuild/rules_pkg#1005

### Additional Notes
To remove a warning (rightfully treated as error) implied by the latter,
this implies to also bump `bazel_skylib`:
> For repository 'bazel_skylib', the root module requires module version
> [email protected], but got [email protected] in the resolved
> dependency graph.
gh-worker-dd-mergequeue-cf854d bot pushed a commit to DataDog/datadog-agent that referenced this pull request Feb 6, 2026
### What does this PR do?
Bump `rules_pkg` from archived release 1.2.0 to current `main` branch to benefit from recent bugfixes.

### Motivation
The `main` branch includes unreleased fixes:
- Bazel 9 compatibility, for when we feel ready to switch to it,
- enhanced RPM support so that it's now possible to build RPMs from within Ubuntu CI containers, also with debuginfo: bazelbuild/rules_pkg#1006
- dependency on a deprecated target: bazelbuild/rules_pkg#1005

### Additional Notes
To remove a warning (rightfully treated as error) implied by the latter, this implies to also bump `bazel_skylib`:
> For repository 'bazel_skylib', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph.

Co-authored-by: regis.desgroppes <[email protected]>
alopezz pushed a commit to DataDog/datadog-agent that referenced this pull request Feb 6, 2026
### What does this PR do?
Bump `rules_pkg` from archived release 1.2.0 to current `main` branch to benefit from recent bugfixes.

### Motivation
The `main` branch includes unreleased fixes:
- Bazel 9 compatibility, for when we feel ready to switch to it,
- enhanced RPM support so that it's now possible to build RPMs from within Ubuntu CI containers, also with debuginfo: bazelbuild/rules_pkg#1006
- dependency on a deprecated target: bazelbuild/rules_pkg#1005

### Additional Notes
To remove a warning (rightfully treated as error) implied by the latter, this implies to also bump `bazel_skylib`:
> For repository 'bazel_skylib', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph.

Co-authored-by: regis.desgroppes <[email protected]>
aiuto pushed a commit to aiuto/rules_pkg that referenced this pull request Feb 22, 2026
This upgrade of `bazel_skylib` from version 1.7.1 to 1.9.0 eliminates
a few deprecation warnings when executing Bazel commands:
> WARNING: [...]: target '[...]' depends on deprecated target
> '@@bazel_tools//src/conditions:host_windows_x64_constraint': No longer
> used by Bazel and will be removed in the future. Migrate to toolchains
> or define your own version of this setting.

These warnings originated from `bazel_skylib` 1.7.1's use of the
deprecated `@bazel_tools//src/conditions:host_windows` constraint in
`copy_file` and `diff_test rules`.
Since version 1.8.0, `bazel_skylib` migrated away from this deprecated
constraint (see bazelbuild/bazel-skylib#574).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants