fix(rpm): propagate main() return code as process exit code#1024
Merged
cgrindel merged 1 commit intobazelbuild:mainfrom Feb 18, 2026
Merged
fix(rpm): propagate main() return code as process exit code#1024cgrindel merged 1 commit intobazelbuild:mainfrom
cgrindel merged 1 commit intobazelbuild:mainfrom
Conversation
Wrap the main() call with sys.exit() so that non-zero return values from main() are properly reflected in the process exit code.
cgrindel
approved these changes
Feb 14, 2026
Contributor
Author
|
@cgrindel mind submitting this, I'm not able to do so. Thanks for the review! |
Contributor
|
I should have realized this when working on #1006, good catch! |
rdesgroppes
added a commit
to DataDog/datadog-agent
that referenced
this pull request
Feb 21, 2026
### What does this PR do? Bump `rules_pkg` to Feb 21 `main, picking up: - bazelbuild/rules_pkg#1021 - bazelbuild/rules_pkg#1024 - bazelbuild/rules_pkg#1025 ### Motivation The missing exit code propagation fixed by bazelbuild/rules_pkg#1024 is the main driver of this change because RPM build errors would go unnoticed.
rdesgroppes
added a commit
to DataDog/datadog-agent
that referenced
this pull request
Mar 20, 2026
### What does this PR do? Bump `rules_pkg` to Feb 21 `main, picking up: - bazelbuild/rules_pkg#1021 - bazelbuild/rules_pkg#1024 - bazelbuild/rules_pkg#1025 ### Motivation The missing exit code propagation fixed by bazelbuild/rules_pkg#1024 is the main driver of this change because RPM build errors would go unnoticed.
rdesgroppes
added a commit
to DataDog/datadog-agent
that referenced
this pull request
Mar 20, 2026
What does this PR do? bump rules_pkg to Mar 17 main, picking up: - bazelbuild/rules_pkg#1024: RPM build errors would go unnoticed without it - bazelbuild/rules_pkg#1035: affects reproducibiliy of builds - bazelbuild/rules_pkg#1044 - bazelbuild/rules_pkg#1046: a contribution of ours (@chouquette) - bazelbuild/rules_pkg#1047: we might need this
gh-worker-dd-mergequeue-cf854d bot
pushed a commit
to DataDog/datadog-agent
that referenced
this pull request
Mar 20, 2026
### What does this PR do? Bump `rules_pkg` to current `main`. ### Motivation Pick up: - bazelbuild/rules_pkg#1021: a contribution of ours - bazelbuild/rules_pkg#1024: RPM build errors would go unnoticed without it - bazelbuild/rules_pkg#1035: affects reproducibiliy of builds - bazelbuild/rules_pkg#1044 - bazelbuild/rules_pkg#1046: another contribution of ours (@chouquette) - bazelbuild/rules_pkg#1047: we might need this feature Co-authored-by: regis.desgroppes <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrap the main() call with sys.exit() so that non-zero return values from main() are properly reflected in the process exit code.
Fixes #1023