Ensure runfiles.{,root_}symlinks makes it into tarballs#1025
Merged
tonyaiuto merged 1 commit intobazelbuild:mainfrom Feb 19, 2026
Merged
Ensure runfiles.{,root_}symlinks makes it into tarballs#1025tonyaiuto merged 1 commit intobazelbuild:mainfrom
tonyaiuto merged 1 commit intobazelbuild:mainfrom
Conversation
Right now we only add files. This is problematic when creating a tarball of an sh_binary(). Starting with Bazel 9, sh_binary() is no longer provided by Bazel itself. In that case rules_shell will declare its own copy of runfiles.bash, putting a symlink at the old location in the runfiles directory.
EdSchouten
force-pushed
the
eschouten/20260212-symlinks
branch
from
f24831f to
7190d4b
Compare
tonyaiuto
approved these changes
Feb 19, 2026
Contributor
Author
|
Thanks! |
rdesgroppes
added a commit
to DataDog/datadog-agent
that referenced
this pull request
Feb 21, 2026
### What does this PR do? Bump `rules_pkg` to Feb 21 `main, picking up: - bazelbuild/rules_pkg#1021 - bazelbuild/rules_pkg#1024 - bazelbuild/rules_pkg#1025 ### Motivation The missing exit code propagation fixed by bazelbuild/rules_pkg#1024 is the main driver of this change because RPM build errors would go unnoticed.
rdesgroppes
added a commit
to DataDog/datadog-agent
that referenced
this pull request
Mar 20, 2026
### What does this PR do? Bump `rules_pkg` to Feb 21 `main, picking up: - bazelbuild/rules_pkg#1021 - bazelbuild/rules_pkg#1024 - bazelbuild/rules_pkg#1025 ### Motivation The missing exit code propagation fixed by bazelbuild/rules_pkg#1024 is the main driver of this change because RPM build errors would go unnoticed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now we only add files. This is problematic when creating a tarball of an sh_binary(). Starting with Bazel 9, sh_binary() is no longer provided by Bazel itself. In that case rules_shell will declare its own copy of runfiles.bash, putting a symlink at the old location in the runfiles directory.