Skip to content

Allow $(var) substitution in filenames#620

Merged
aiuto merged 2 commits intobazelbuild:mainfrom
aiuto:vars
Oct 10, 2022
Merged

Allow $(var) substitution in filenames#620
aiuto merged 2 commits intobazelbuild:mainfrom
aiuto:vars

Conversation

@aiuto
Copy link
Collaborator

@aiuto aiuto commented Oct 7, 2022

Allow $(var) substitution in filenames and include everything in ctx.var in the substitution dictionary.

Fixes #520

@aiuto aiuto requested a review from nacl as a code owner October 7, 2022 01:12
@aiuto aiuto requested review from cgrindel and jylinv0 and removed request for nacl October 7, 2022 02:04
@aiuto
Copy link
Collaborator Author

aiuto commented Oct 7, 2022

This seems like an unimportant thing to do right now, but it unblocked moving Google over to pkg_deb from a legacy tool. That will increase the likelihood that I can get other people to work on the tools.

@aiuto aiuto requested review from buildbreaker2021 and removed request for cgrindel October 7, 2022 15:24
@aiuto aiuto merged commit 30bf21d into bazelbuild:main Oct 10, 2022
@aiuto aiuto deleted the vars branch October 10, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

package variables should support $(var) expansion for backwards compatibility to MakeVars

2 participants