feat: expose tar manifest as an output#643
Merged
aiuto merged 2 commits intobazelbuild:mainfrom Jan 11, 2023
alexeagle:manifest_output
Merged
feat: expose tar manifest as an output#643aiuto merged 2 commits intobazelbuild:mainfrom alexeagle:manifest_output
aiuto merged 2 commits intobazelbuild:mainfrom
alexeagle:manifest_output
Conversation
Collaborator
|
This will only lead to disappointment. @nacl is about to change the format to JSON. |
Contributor
Author
|
Well in the last two weeks I've already started depending on it. If and when you change the format, I'll adapt. Would you accept the PR if it was documented as Internal Only so you're not obligated to support it? |
aiuto
reviewed
Dec 14, 2022
Collaborator
|
Sure. By 1.0 it will be fairly stable, but I expect some churn in the next
few months.
Of course, people wanting to get at the intermediate form leads me to a
question.
Should there be a new generic packaging type here, or are their various
language
specific packaging types that could benefit from a declared interface from
pkg_* rules
manifests.
As I write that, this brings up another question. Do you need to get the
manifest
from pkg_tar specifically, or would a rule to simply produce the manifest
be the
thing you really want?
Gah.... now the feature creep is hitting me. Should we be able to
interject a
manifest builder, so we can create a MANIFEST file that is a member of a
.zip or .jar file as it is created.
… Message ID: ***@***.***>
|
This allows targets to run something like jq over the manifest contents
aiuto
approved these changes
Jan 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows targets to run something like jq over the manifest contents