Align pkg_rpm returned files with other rules#692
Merged
aiuto merged 4 commits intobazelbuild:mainfrom Oct 16, 2023
Merged
Conversation
pkg_rpm returns the package file named after `package_file_name` and a symbolic link to the file called `target_name`, while other rules do not return the symbolic link.
Collaborator
|
Leaving this one for @nacl. They are the RPM expert and heavy user. |
aiuto
approved these changes
Aug 14, 2023
Collaborator
aiuto
left a comment
aiuto
left a comment
There was a problem hiding this comment.
Sorry for the lack of response here.
This seems fine. Now that I read it carefully, I see that very little is actually changing. The PR description had me looking for more.
Collaborator
|
Still trying to get a handle on the CI failures. It doesn't make sense. |
Collaborator
|
Friendly ping. Can you try to update your branch and push again so we can see if CI is cleared up? |
k0walik
requested review from
alexeagle,
dannysullivan and
jylinv0
as code owners
Contributor
Author
|
Done! The CI is passing. |
Collaborator
|
Does this fix #685? |
Contributor
Author
|
Yes, we can close that one |
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pkg_rpmreturns both package file and a symbolic link, while other rules return only the actual file.This is a follow up PR on the comment in #685.