Write debian changes Date field in UTC rather than local time#712
Write debian changes Date field in UTC rather than local time#712aiuto merged 1 commit intobazelbuild:mainfrom
Conversation
|
@tetromino was pkg_deb_test one of the rules_pkg things broken at head? |
|
Very strange. Now the tests are failing on mac because of some strange unicode handling of the Description field. |
|
I can reproduce this in local testing on my Macbook with Bazel HEAD; everything worked fine with 6.2.1 rules_pkg python code is correct AFAICT. Something in Bazel at HEAD broke argument encoding in spawned processes on macOS :/ |
|
bazelbuild/bazel#18792 - update to JDK 20 broke non-ascii argument encoding on macOS. |
|
I think I should insist you squash these commits into one commit. |
That rebase is tricky. It fails on each squashed change and I have to hand edit. The merge squashes it. |
|
Oh... the tests are failing for orthogonal reasons.. |
|
I rebased it down. You can't tell in the github UI though. |
|
For me in manual testing, after bazelbuild/bazel@f00439d, //tests/deb:pkg_deb_test passes on macOS. But it still fails on the CI machine at the exact same git commit :/ |
This fixes some subtle problems caused by having CI and developer machines in different time zones.
It's also the right thing.